# HG changeset patch # User Ingo Weinzierl # Date 1276252130 0 # Node ID 27029f0ec7e1497609d23f0bd59f43189349092e # Parent f55692e3e0ce10ceef95fc09bf6972053ce11619 Reverted the changes of rev1194. gnv/trunk@1199 c6561f87-3c4e-4783-a992-168aeb5c3f6f diff -r f55692e3e0ce -r 27029f0ec7e1 gnv/ChangeLog --- a/gnv/ChangeLog Fri Jun 11 09:25:44 2010 +0000 +++ b/gnv/ChangeLog Fri Jun 11 10:28:50 2010 +0000 @@ -1,3 +1,15 @@ +2010-06-11 Ingo Weinzierl + + * src/main/java/de/intevation/gnv/artifactdatabase/client/ArtifactDatabaseClient.java, + src/main/java/de/intevation/gnv/action/DescribeUIAction.java, + src/main/java/de/intevation/gnv/action/NextArtifactStepAction.java, + src/main/java/de/intevation/gnv/util/XSLTransformer.java, + src/main/webapp/styles/gnv.css, + src/main/webapp/WEB-INF/config/struts-config.xml, + src/main/webapp/WEB-INF/config/templates/describe-ui.xsl, + src/main/webapp/WEB-INF/jsp/index.jsp: Reverted the changes of rev1194 - + the feature implemented in rev1194 has not been finished so far. + 2010-06-11 Tim Englich * src/main/webapp/scripts/viewport.jsp, diff -r f55692e3e0ce -r 27029f0ec7e1 gnv/src/main/java/de/intevation/gnv/action/DescribeUIAction.java --- a/gnv/src/main/java/de/intevation/gnv/action/DescribeUIAction.java Fri Jun 11 09:25:44 2010 +0000 +++ b/gnv/src/main/java/de/intevation/gnv/action/DescribeUIAction.java Fri Jun 11 10:28:50 2010 +0000 @@ -25,8 +25,6 @@ import de.intevation.gnv.util.XMLUtils; import de.intevation.gnv.util.XSLTransformer; -import org.apache.log4j.Logger; - /** * This controller is called to fetch the current artifact description using the * describe operation. The describe document is used to feed an XSL transformer @@ -38,9 +36,6 @@ */ public class DescribeUIAction extends ArtifactDatabaseActionBase { - private static Logger log = Logger - .getLogger(DescribeUIAction.class); - public static final String XPATH_DYNAMIC_UI = "art:dynamic"; public static final String XPATH_STATIC_UI = "art:static"; @@ -63,11 +58,6 @@ super(); } - public static String getInputException(HttpServletRequest request) { - Object msg = request.getAttribute(CommunicationKeys.REQUEST_EXCEPTION_INPUT_ID); - return msg != null ? msg.toString() : ""; - } - @Override public ActionForward execute( @@ -114,10 +104,8 @@ if (currentUI != null) { ResourceBundle res = ResourceBundle.getBundle( "applicationMessages", locale); - String editText = res.getString( + String editText = res.getString( "gnviewer.history.back.button"); - String submitButton = res.getString( - "gnviewer.select.button.src"); String exampleLinestring = res.getString( "gnviewer.example.linestring"); String examplePolygon = res.getString( @@ -125,37 +113,12 @@ XSLTransformer transformer = new XSLTransformer(); - String nextUrl = response.encodeURL( - mapping.findForward("next").getPath()); - String url = response.encodeURL( mapping.findForward("back").getPath()); - - - transformer.addParameter( - "uuid", - sm.getCurrentArtifact().getDescription()); - - transformer.addParameter( - "exception", - getInputException(request)); - - - Object ft = request.getAttribute("furthertargets"); - - transformer.addParameter("further", - ft == null || (ft instanceof Boolean && ((Boolean)ft).booleanValue()) - ? "true" - : "false"); - - transformer.addParameter("next-url", nextUrl); transformer.addParameter("back-url", url); transformer.addParameter("edit", editText); transformer.addParameter("example-polygon", examplePolygon); transformer.addParameter( - "gnviewer-select-button-src", - submitButton); - transformer.addParameter( "example-linestring", exampleLinestring); @@ -172,9 +135,10 @@ ); String ui = transformer.transform( - dynamicNode.getParentNode(), + dynamicNode, "UTF-8", - request.getRealPath(XSL_SHEET_DYNAMIC)); + request.getRealPath(XSL_SHEET_DYNAMIC + )); if (ui != null && ui.length() > 1) request.setAttribute("ui", ui); diff -r f55692e3e0ce -r 27029f0ec7e1 gnv/src/main/java/de/intevation/gnv/action/NextArtifactStepAction.java --- a/gnv/src/main/java/de/intevation/gnv/action/NextArtifactStepAction.java Fri Jun 11 09:25:44 2010 +0000 +++ b/gnv/src/main/java/de/intevation/gnv/action/NextArtifactStepAction.java Fri Jun 11 10:28:50 2010 +0000 @@ -98,7 +98,7 @@ ); } catch (ArtifactDatabaseInputException e) { - log.debug(e, e); + log.error(e, e); request.setAttribute( CommunicationKeys.REQUEST_EXCEPTION_INPUT_ID, e.getMessage()); @@ -113,7 +113,7 @@ Map tmpOuts = ad.getOutputModes(); request.setAttribute( "furthertargets", - Boolean.valueOf(tmpOuts == null || tmpOuts.isEmpty()) + tmpOuts == null || tmpOuts.isEmpty() ); } else { try{ @@ -139,7 +139,7 @@ e.getMessage()); } - request.setAttribute("furthertargets", Boolean.FALSE); + request.setAttribute("furthertargets", false); } }else{ log.warn("SessionTimeout has occured"); diff -r f55692e3e0ce -r 27029f0ec7e1 gnv/src/main/java/de/intevation/gnv/artifactdatabase/client/ArtifactDatabaseClient.java --- a/gnv/src/main/java/de/intevation/gnv/artifactdatabase/client/ArtifactDatabaseClient.java Fri Jun 11 09:25:44 2010 +0000 +++ b/gnv/src/main/java/de/intevation/gnv/artifactdatabase/client/ArtifactDatabaseClient.java Fri Jun 11 10:28:50 2010 +0000 @@ -25,11 +25,9 @@ */ public interface ArtifactDatabaseClient { - public final static String ARTIFACTDATABASE_COUNT_ID = - "de.intevation.gnv.artifactdatabase.client.ArtifactDatabase.count"; + public final static String ARTIFACTDATABASE_COUNT_ID = "de.intevation.gnv.artifactdatabase.client.ArtifactDatabase.count"; - public final static String ARTIFACTDATABASE_URL_ID = - "de.intevation.gnv.artifactdatabase.client.ArtifactDatabase.url"; + public final static String ARTIFACTDATABASE_URL_ID = "de.intevation.gnv.artifactdatabase.client.ArtifactDatabase.url"; /** * Return the Artifactfactories which can be resolved. diff -r f55692e3e0ce -r 27029f0ec7e1 gnv/src/main/java/de/intevation/gnv/util/XSLTransformer.java --- a/gnv/src/main/java/de/intevation/gnv/util/XSLTransformer.java Fri Jun 11 09:25:44 2010 +0000 +++ b/gnv/src/main/java/de/intevation/gnv/util/XSLTransformer.java Fri Jun 11 10:28:50 2010 +0000 @@ -98,7 +98,7 @@ */ public void addParameter(String name, String value) { if (params == null) { - params = new HashMap(); + params = new HashMap(3); } params.put(name, value); diff -r f55692e3e0ce -r 27029f0ec7e1 gnv/src/main/webapp/WEB-INF/config/struts-config.xml --- a/gnv/src/main/webapp/WEB-INF/config/struts-config.xml Fri Jun 11 09:25:44 2010 +0000 +++ b/gnv/src/main/webapp/WEB-INF/config/struts-config.xml Fri Jun 11 10:28:50 2010 +0000 @@ -91,9 +91,6 @@ - @@ -109,9 +106,6 @@ name="back" path="/gnv/back.do"/> - @@ -130,9 +124,6 @@ - @@ -158,9 +149,6 @@ - @@ -192,9 +180,6 @@ - @@ -209,9 +194,6 @@ - @@ -226,9 +208,6 @@ - @@ -240,9 +219,6 @@ type="de.intevation.gnv.action.ShowStatisticAction" scope="request" validate="false"> - @@ -261,9 +237,6 @@ name="back" path="/gnv/back.do"/> - - diff -r f55692e3e0ce -r 27029f0ec7e1 gnv/src/main/webapp/WEB-INF/config/templates/describe-ui.xsl --- a/gnv/src/main/webapp/WEB-INF/config/templates/describe-ui.xsl Fri Jun 11 09:25:44 2010 +0000 +++ b/gnv/src/main/webapp/WEB-INF/config/templates/describe-ui.xsl Fri Jun 11 10:28:50 2010 +0000 @@ -11,45 +11,19 @@ - /gnv/next.do - false - - ./images/auswaehlen.png - - -
-
-
- -
- - -

Here i am

-

""

- -
- - -
-
-
- - + - + @@ -64,12 +38,12 @@ @@ -77,7 +51,7 @@ - + @@ -103,7 +77,7 @@ - + @@ -113,7 +87,7 @@ - +
@@ -178,7 +152,7 @@ - + @@ -207,7 +181,7 @@ - + diff -r f55692e3e0ce -r 27029f0ec7e1 gnv/src/main/webapp/WEB-INF/jsp/index.jsp --- a/gnv/src/main/webapp/WEB-INF/jsp/index.jsp Fri Jun 11 09:25:44 2010 +0000 +++ b/gnv/src/main/webapp/WEB-INF/jsp/index.jsp Fri Jun 11 10:28:50 2010 +0000 @@ -1,10 +1,13 @@ <%@ taglib uri="http://jakarta.apache.org/struts/tags-bean" prefix="bean" %> <%@ taglib uri="http://jakarta.apache.org/struts/tags-bean-el" prefix="bean-el" %> +<%@page import="java.util.Collection"%> <%@page import="de.intevation.gnv.artifactdatabase.objects.ArtifactObject"%> <%@page import="de.intevation.gnv.action.CommunicationKeys"%> <%@page import="de.intevation.gnv.action.sessionmodel.SessionModel"%> <%@page import="de.intevation.gnv.action.sessionmodel.SessionModelFactory"%> +<%@page import="java.util.Iterator"%> <% + String exception = (String)request.getAttribute(CommunicationKeys.REQUEST_EXCEPTION_INPUT_ID); SessionModel sm = SessionModelFactory.getInstance().getSessionModel(request); Object ui = request.getAttribute("ui"); Object staticui = request.getAttribute("staticui"); @@ -12,6 +15,7 @@ Object statistic = request.getAttribute("statistic"); Object histogram = request.getAttribute("histogram"); Object wms_published = request.getAttribute("wms_published"); + boolean furthertargets = true; if (chart == null && statistic == null && histogram == null && wms_published == null) { boolean supportChart = sm.getOutputMode("chart") != null; @@ -20,6 +24,10 @@ } } + Object furthertargetsObject = request.getAttribute("furthertargets"); + if (furthertargetsObject != null){ + furthertargets = ((Boolean)furthertargetsObject).booleanValue(); + } Object exceptionMessage = request.getAttribute(CommunicationKeys.REQUEST_EXCEPTION_MESSAGE_ID); exceptionMessage = (exceptionMessage != null ? exceptionMessage.toString().replaceAll(" ", ".").replaceAll(":",".").toLowerCase() : null); @@ -86,8 +94,24 @@ <%}%> <%-- render the dynamic part to feed the state and advance to the next state --%> - <%if (ui != null) { %> - <%= ui.toString().replaceAll(" ", "") %> + <%if (ui != null){%> +
+
" method="post"> +
+ + <%-- error message, if user input was not valid --%> + <%if (exception != null) {%> +
<%=exception%>
+ <%}%> + <%=ui != null ? ui.toString().replaceAll(" ", "") : "" %> + + <%if(furthertargets){%> +
+ "/> + <%}%> +
+
+
<%}%> <%-- render export options if existing for this state --%> diff -r f55692e3e0ce -r 27029f0ec7e1 gnv/src/main/webapp/styles/gnv.css --- a/gnv/src/main/webapp/styles/gnv.css Fri Jun 11 09:25:44 2010 +0000 +++ b/gnv/src/main/webapp/styles/gnv.css Fri Jun 11 10:28:50 2010 +0000 @@ -117,14 +117,6 @@ } /* Some classes for the content */ -a.linkButton { - border: 1px solid #000000; - color: #ff6600; - font-size: 1.2em; - padding: 1px; - text-decoration: none; -} - #contentElement { float: left; height: 90%;