# HG changeset patch # User Sascha L. Teichmann # Date 1255339156 0 # Node ID b5e55f460f0b2cc9f7e85a116d3d5df0bf9eedb9 # Parent 7fb9441dd8af776aba0223bd262698882fd02eda Closed small file descriptor leak in loading SQL properties file. gnv-artifacts/trunk@209 c6561f87-3c4e-4783-a992-168aeb5c3f6f diff -r 7fb9441dd8af -r b5e55f460f0b gnv-artifacts/ChangeLog --- a/gnv-artifacts/ChangeLog Fri Oct 09 07:54:48 2009 +0000 +++ b/gnv-artifacts/ChangeLog Mon Oct 12 09:19:16 2009 +0000 @@ -1,3 +1,8 @@ +2009-10-12 Sascha L. Teichmann + + * src/main/java/de/intevation/gnv/artifacts/context/GNVArtifactContextFactory.java: + Closed small file descriptor leak. + 2009-10-09 Tim Englich * src/main/java/de/intevation/gnv/**/*.java Edited: diff -r 7fb9441dd8af -r b5e55f460f0b gnv-artifacts/src/main/java/de/intevation/gnv/artifacts/context/GNVArtifactContextFactory.java --- a/gnv-artifacts/src/main/java/de/intevation/gnv/artifacts/context/GNVArtifactContextFactory.java Fri Oct 09 07:54:48 2009 +0000 +++ b/gnv-artifacts/src/main/java/de/intevation/gnv/artifacts/context/GNVArtifactContextFactory.java Mon Oct 12 09:19:16 2009 +0000 @@ -90,9 +90,18 @@ private Properties getProperties(String filePath) throws FileNotFoundException, IOException { - InputStream inputStream = new FileInputStream(filePath); - Properties properties = new Properties(); - properties.load(inputStream); - return properties; + InputStream inputStream = null; + try { + inputStream = new FileInputStream(filePath); + Properties properties = new Properties(); + properties.load(inputStream); + return properties; + } + finally { + if (inputStream != null) { + try { inputStream.close(); } + catch (IOException ioe) {} + } + } } }