comparison flys-artifacts/src/main/java/de/intevation/flys/artifacts/datacage/templating/Builder.java @ 5779:ebec12def170

Datacage: Add a pool of builders to make it multi threadable. XML DOM is not thread safe. Therefore the old implementation only allowed one thread to use the builder at a time. As the complexity of the configuration has increased over time this has become a bottleneck of the whole application because it took quiet some time to build a result. Furthermore the builder code path is visited very frequent. So many concurrent requests were piled up resulting in long waits for the users. To mitigate this problem a round robin pool of builders is used now. Each of the pooled builders has an independent copy of the XML template and can be run in parallel. The number of builders is determined by the system property 'flys.datacage.pool.size'. It defaults to 4.
author Sascha L. Teichmann <teichmann@intevation.de>
date Sun, 21 Apr 2013 12:48:09 +0200
parents 55529f586962
children
comparison
equal deleted inserted replaced
5778:4a1bd43e7aa6 5779:ebec12def170
124 new HashMap<String, CompiledStatement.Instance>(); 124 new HashMap<String, CompiledStatement.Instance>();
125 } 125 }
126 126
127 public void build() throws SQLException { 127 public void build() throws SQLException {
128 try { 128 try {
129 synchronized (template) { 129 // XXX: Thread safety is now established by the builder pool.
130 //synchronized (template) {
130 for (Node current: rootsToList()) { 131 for (Node current: rootsToList()) {
131 build(output, current); 132 build(output, current);
132 } 133 }
133 } 134 //}
134 } 135 }
135 finally { 136 finally {
136 closeStatements(); 137 closeStatements();
137 } 138 }
138 } 139 }

http://dive4elements.wald.intevation.org