Mercurial > dive4elements > river
comparison artifacts/src/main/java/org/dive4elements/river/artifacts/model/minfo/SedimentLoadFactory.java @ 7254:fe32a7f9655e
Reduce usage of careless 'for (int i = 0; i < x.size(); i++)' pattern.
author | Sascha L. Teichmann <teichmann@intevation.de> |
---|---|
date | Sat, 05 Oct 2013 17:52:16 +0200 |
parents | 1dff8e71c4d6 |
children | 615795d54831 |
comparison
equal
deleted
inserted
replaced
7253:90a3bcd8060a | 7254:fe32a7f9655e |
---|---|
321 sqlQuery.setString("name", river); | 321 sqlQuery.setString("name", river); |
322 sqlQuery.setDouble("startKm", startKm); | 322 sqlQuery.setDouble("startKm", startKm); |
323 sqlQuery.setDouble("endKm", endKm); | 323 sqlQuery.setDouble("endKm", endKm); |
324 List<Object []> results = sqlQuery.list(); | 324 List<Object []> results = sqlQuery.list(); |
325 SedimentLoad[] loads = new SedimentLoad[results.size()]; | 325 SedimentLoad[] loads = new SedimentLoad[results.size()]; |
326 for (int i = 0; i < results.size(); i++) { | 326 for (int i = 0, R = results.size(); i < R; i++) { |
327 Object[] row = results.get(i); | 327 Object[] row = results.get(i); |
328 loads[i] = new SedimentLoad( | 328 loads[i] = new SedimentLoad( |
329 (String) row[0], | 329 (String) row[0], |
330 (Date) row[1], | 330 (Date) row[1], |
331 null, | 331 null, |
343 sqlQuery.setDouble("startKm", startKm); | 343 sqlQuery.setDouble("startKm", startKm); |
344 sqlQuery.setDouble("endKm", endKm); | 344 sqlQuery.setDouble("endKm", endKm); |
345 List<Object []> results = sqlQuery.list(); | 345 List<Object []> results = sqlQuery.list(); |
346 | 346 |
347 SedimentLoad[] loads = new SedimentLoad[results.size()]; | 347 SedimentLoad[] loads = new SedimentLoad[results.size()]; |
348 for (int i = 0; i < results.size(); i++) { | 348 for (int i = 0, R = results.size(); i < R; i++) { |
349 Object[] row = results.get(i); | 349 Object[] row = results.get(i); |
350 loads[i] = new SedimentLoad( | 350 loads[i] = new SedimentLoad( |
351 (String) row[0], | 351 (String) row[0], |
352 (Date) row[1], | 352 (Date) row[1], |
353 (Date) row[2], | 353 (Date) row[2], |
364 sqlQuery.setDouble("startKm", startKm); | 364 sqlQuery.setDouble("startKm", startKm); |
365 sqlQuery.setDouble("endKm", endKm); | 365 sqlQuery.setDouble("endKm", endKm); |
366 List<Object []> results = sqlQuery.list(); | 366 List<Object []> results = sqlQuery.list(); |
367 | 367 |
368 SedimentLoad[] loads = new SedimentLoad[results.size()]; | 368 SedimentLoad[] loads = new SedimentLoad[results.size()]; |
369 for (int i = 0; i < results.size(); i++) { | 369 for (int i = 0, R = results.size(); i < R; i++) { |
370 Object[] row = results.get(i); | 370 Object[] row = results.get(i); |
371 loads[i] = new SedimentLoad( | 371 loads[i] = new SedimentLoad( |
372 ((Date) row[0]).toString() + (Date) row[1], | 372 ((Date) row[0]).toString() + (Date) row[1], |
373 (Date) row[0], | 373 (Date) row[0], |
374 (Date) row[1], | 374 (Date) row[1], |
453 TreeMap<Double,MeasurementStation> relevantStations = | 453 TreeMap<Double,MeasurementStation> relevantStations = |
454 fraction.equals("suspended_sediment") /* || TODO clarify: fraction.equals("susp_sand") */ | 454 fraction.equals("suspended_sediment") /* || TODO clarify: fraction.equals("susp_sand") */ |
455 ? suspStations | 455 ? suspStations |
456 : floatStations; | 456 : floatStations; |
457 | 457 |
458 for (int i = 0; i < results.size(); i++) { | 458 for (int i = 0, R = results.size(); i < R; i++) { |
459 row = results.get(i); | 459 row = results.get(i); |
460 double km = (Double) row[2]; | 460 double km = (Double) row[2]; |
461 Range range = findMeasurementStationRange(relevantStations, km); | 461 Range range = findMeasurementStationRange(relevantStations, km); |
462 if (range == null) { | 462 if (range == null) { |
463 log.warn("No measurement station for " + fraction + " km " + km); | 463 log.warn("No measurement station for " + fraction + " km " + km); |
606 (Date) row[1], | 606 (Date) row[1], |
607 (Date) row[4], | 607 (Date) row[4], |
608 true, | 608 true, |
609 (String)row[5]); | 609 (String)row[5]); |
610 TDoubleArrayList kms = new TDoubleArrayList(); | 610 TDoubleArrayList kms = new TDoubleArrayList(); |
611 for (int i = 0; i < results.size(); i++) { | 611 for (int i = 0, R = results.size(); i < R; i++) { |
612 row = results.get(i); | 612 row = results.get(i); |
613 kms.add((Double)row[3]); | 613 kms.add((Double)row[3]); |
614 load.setLoadTotal((Double)row[3], (Double)row[2]); | 614 load.setLoadTotal((Double)row[3], (Double)row[2]); |
615 } | 615 } |
616 } | 616 } |
678 (Date) row[4], | 678 (Date) row[4], |
679 true, | 679 true, |
680 (String)row[5]); | 680 (String)row[5]); |
681 } | 681 } |
682 | 682 |
683 for (int i = 0; i < results.size(); i++) { | 683 for (int i = 0, R = results.size(); i < R; i++) { |
684 Object[] row = results.get(i); | 684 Object[] row = results.get(i); |
685 double km = (Double)row[3]; | 685 double km = (Double)row[3]; |
686 Range range = findMeasurementStationRange(stations, km); | 686 Range range = findMeasurementStationRange(stations, km); |
687 if (range == null) { | 687 if (range == null) { |
688 log.warn("No measurement station for " + fraction + " km " + km); | 688 log.warn("No measurement station for " + fraction + " km " + km); |
797 (Date) row[1], | 797 (Date) row[1], |
798 (Date) row[2], | 798 (Date) row[2], |
799 false, | 799 false, |
800 (String)row[5]); | 800 (String)row[5]); |
801 | 801 |
802 for (int i = 0; i < results.size(); i++) { | 802 for (int i = 0, R = results.size(); i < R; i++) { |
803 row = results.get(i); | 803 row = results.get(i); |
804 SedimentLoadFraction fraction = new SedimentLoadFraction(); | 804 SedimentLoadFraction fraction = new SedimentLoadFraction(); |
805 fraction.setUnknown((Double)row[3]); | 805 fraction.setUnknown((Double)row[3]); |
806 load.addKm((Double)row[4], fraction); | 806 load.addKm((Double)row[4], fraction); |
807 } | 807 } |