diff flys-client/src/main/java/de/intevation/flys/client/client/ui/DatacageTwinPanel.java @ 1307:489e6a82fe84

Partial fix for flys/issue304 (Erweiterte Funktionen W-Differenzen). flys-client/trunk@2941 c6561f87-3c4e-4783-a992-168aeb5c3f6f
author Felix Wolfsteller <felix.wolfsteller@intevation.de>
date Wed, 12 Oct 2011 06:59:42 +0000
parents 014fc183c640
children d194bee456d3
line wrap: on
line diff
--- a/flys-client/src/main/java/de/intevation/flys/client/client/ui/DatacageTwinPanel.java	Tue Oct 11 13:25:18 2011 +0000
+++ b/flys-client/src/main/java/de/intevation/flys/client/client/ui/DatacageTwinPanel.java	Wed Oct 12 06:59:42 2011 +0000
@@ -1,7 +1,6 @@
 package de.intevation.flys.client.client.ui;
 
 import java.util.ArrayList;
-import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -188,6 +187,7 @@
             // TODO i18n of error message. (MSG.no_waterlevel_pair_selected())
             errors.add("No pair of waterlevel items selected");
         }
+        // Check whether minuend and subtrahend are equal.
 
         return errors;
     }
@@ -230,9 +230,12 @@
         Config config = Config.getInstance();
         ListGridRecord[] records = differencesList.getRecords();
 
-        // Use LinkedHashSet to keep the order.
-        Set<Recommendation> ar  = new LinkedHashSet<Recommendation>();
-        Set<Recommendation> all = new LinkedHashSet<Recommendation>();
+        // TODO Problem when same facet participates in two diffs.
+        //
+        // Resolve whether "new" ones were already cloned.
+
+        List<Recommendation> ar  = new ArrayList<Recommendation>();
+        List<Recommendation> all = new ArrayList<Recommendation>();
         for (ListGridRecord record : records) {
             RecommendationPairRecord r =
                 (RecommendationPairRecord) record;
@@ -301,6 +304,9 @@
     }
 
 
+    /**
+     * Creates part of the String that encodes minuend or subtrahend.
+     */
     protected String createDataString(String artifact, Filter filter) {
         Facet f = null;
 
@@ -318,19 +324,5 @@
 
         return "[" + artifact + ";" + f.getName() + ";" + f.getIndex() + "]";
     }
-
-    /*@Override
-    protected Data[] getData() {
-        // TODO ToLoadRecord ! 
-        String value = "TODO:FIND VALUE";
-        if (toLoad1 != null) {
-            List<Recommendation> recommendations = toLoad1.toRecommendations();
-            value = recommendations.get(0).getIDs();
-        }
-        DataItem item1 = new DefaultDataItem(dataName, dataName, value);
-        DataItem item2 = new DefaultDataItem(dataName, dataName, value);
-        return new Data[] { new DefaultData(
-            dataName, null, null, new DataItem[] { item1, item2}) };
-    }*/
 }
 // vim:set ts=4 sw=4 si et sta sts=4 fenc=utf8 :

http://dive4elements.wald.intevation.org