diff artifacts/src/main/java/org/dive4elements/river/artifacts/states/WDifferencesState.java @ 8881:6b93a2498e06

Slightly better abstraction for extraction waterlevels via datacage
author gernotbelger
date Fri, 09 Feb 2018 16:11:34 +0100
parents 23264d1a528f
children 3f49835a00c3
line wrap: on
line diff
--- a/artifacts/src/main/java/org/dive4elements/river/artifacts/states/WDifferencesState.java	Fri Feb 09 13:27:10 2018 +0100
+++ b/artifacts/src/main/java/org/dive4elements/river/artifacts/states/WDifferencesState.java	Fri Feb 09 16:11:34 2018 +0100
@@ -111,6 +111,7 @@
      * Access the data (wkms) of an artifact, coded in mingle.
      */
     // FIXME: meanwhile used by several places outside this context; refactor into separate helper class to access waterlevels
+    // FIXME: use org.dive4elements.river.artifacts.states.WaterlevelFetcher instead
     public WKms getWKms(
         String mingle,
         CallContext context,
@@ -160,6 +161,7 @@
                                               getData();
             if (wkms == null || wkms.length == 0) {
                 log.warn("no waterlevels in artifact");
+                // FIXME: fall through will lead to exception...
             }
             else if (wkms.length < idx+1) {
                 log.warn("Not enough waterlevels in artifact.");

http://dive4elements.wald.intevation.org