diff artifacts/src/main/java/org/dive4elements/river/artifacts/model/DataFacet.java @ 8853:8c64617a7991

Some source code comments and fixme's
author gernotbelger
date Thu, 18 Jan 2018 18:33:52 +0100
parents af13ceeba52a
children 3f49835a00c3
line wrap: on
line diff
--- a/artifacts/src/main/java/org/dive4elements/river/artifacts/model/DataFacet.java	Thu Jan 18 18:32:30 2018 +0100
+++ b/artifacts/src/main/java/org/dive4elements/river/artifacts/model/DataFacet.java	Thu Jan 18 18:33:52 2018 +0100
@@ -104,12 +104,14 @@
      */
     @Override
     public Facet deepCopy() {
+    	// FIXME: why not use the full constructor instead? would also fix the next problem
         DataFacet copy = new DataFacet();
+        // FIXME: usage of internal knowledge of parent class...
+        // Either the set method should be correctly overwritten, or implement a correct copy-constructor!
         copy.set(this);
         copy.type    = type;
         copy.hash    = hash;
         copy.stateId = stateId;
         return copy;
     }
-}
-// vim:set ts=4 sw=4 si et sta sts=4 fenc=utf-8 :
+}
\ No newline at end of file

http://dive4elements.wald.intevation.org