diff flys-client/src/main/java/de/intevation/flys/client/server/DistanceInfoServiceImpl.java @ 1367:ab8eb2f544f2

Replaced stdout and stderr logging with log4j loggers in server classes. flys-client/trunk@3069 c6561f87-3c4e-4783-a992-168aeb5c3f6f
author Ingo Weinzierl <ingo.weinzierl@intevation.de>
date Tue, 25 Oct 2011 12:31:15 +0000
parents 78907f0fb939
children bc06a671ef60
line wrap: on
line diff
--- a/flys-client/src/main/java/de/intevation/flys/client/server/DistanceInfoServiceImpl.java	Tue Oct 25 11:07:14 2011 +0000
+++ b/flys-client/src/main/java/de/intevation/flys/client/server/DistanceInfoServiceImpl.java	Tue Oct 25 12:31:15 2011 +0000
@@ -7,6 +7,8 @@
 import org.w3c.dom.Element;
 import org.w3c.dom.NodeList;
 
+import org.apache.log4j.Logger;
+
 import com.google.gwt.user.server.rpc.RemoteServiceServlet;
 
 import de.intevation.artifacts.common.ArtifactNamespaceContext;
@@ -29,6 +31,10 @@
 extends      RemoteServiceServlet
 implements   DistanceInfoService
 {
+    private static final Logger logger =
+        Logger.getLogger(DistanceInfoServiceImpl.class);
+
+
     public static final String ERROR_NO_DISTANCEINFO_FOUND =
         "error_no_distanceinfo_found";
 
@@ -41,7 +47,7 @@
         String river)
     throws ServerException
     {
-        System.out.println("DistanceInfoServiceImpl.getDistanceInfo");
+        logger.info("DistanceInfoServiceImpl.getDistanceInfo");
 
         Document doc = XMLUtils.newDocument();
 
@@ -61,7 +67,7 @@
         try {
             Document result = client.callService(url, "distanceinfo", doc);
 
-            System.out.println("Extract distance info objects now.");
+            logger.debug("Extract distance info objects now.");
             DistanceInfoObject[] objects = extractDistanceInfoObjects(result);
 
             if (objects != null && objects.length > 0) {
@@ -69,7 +75,7 @@
             }
         }
         catch (ConnectionException ce) {
-            System.err.println(ce.getLocalizedMessage());
+            logger.error(ce, ce);
         }
 
         throw new ServerException(ERROR_NO_DISTANCEINFO_FOUND);
@@ -89,12 +95,12 @@
         NodeList list = result.getElementsByTagName("distance");
 
         if (list == null || list.getLength() == 0) {
-            System.err.println("No distance info found.");
+            logger.warn("No distance info found.");
             throw new ServerException(ERROR_NO_DISTANCEINFO_FOUND);
         }
 
         int num = list.getLength();
-        System.out.println("Response contains " + num + " objects.");
+        logger.debug("Response contains " + num + " objects.");
 
         List<DistanceInfoObject> objects =
             new ArrayList<DistanceInfoObject>(num);
@@ -108,7 +114,7 @@
             }
         }
 
-        System.out.println("Retrieved " + objects.size() + " distances.");
+        logger.debug("Retrieved " + objects.size() + " distances.");
 
         return (DistanceInfoObject[])
             objects.toArray(new DistanceInfoObject[num]);
@@ -142,11 +148,11 @@
                 return new DistanceInfoObjectImpl(desc, f, t, riverside, b, tp);
             }
             catch (NumberFormatException nfe) {
-                System.err.println(nfe.getLocalizedMessage());
+                logger.warn(nfe.getLocalizedMessage());
             }
         }
 
-        System.err.println("Invalid distance info object found.");
+        logger.warn("Invalid distance info object found.");
 
         return null;
     }

http://dive4elements.wald.intevation.org