diff flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ChartPropertiesEditor.java @ 4568:bbd82bd8e541

flys-client: Cosmetics and warnings.
author Christian Lins <christian.lins@intevation.de>
date Mon, 19 Nov 2012 00:07:53 +0100
parents 45f2b0778a3a
children b296d435fc69
line wrap: on
line diff
--- a/flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ChartPropertiesEditor.java	Sun Nov 18 01:19:07 2012 +0100
+++ b/flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ChartPropertiesEditor.java	Mon Nov 19 00:07:53 2012 +0100
@@ -1,54 +1,50 @@
 package de.intevation.flys.client.client.ui.chart;
 
-import java.util.LinkedHashMap;
-import java.util.List;
-import java.util.Map;
-
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.user.client.rpc.AsyncCallback;
 
+import com.smartgwt.client.types.Alignment;
 import com.smartgwt.client.util.SC;
+import com.smartgwt.client.widgets.Button;
+import com.smartgwt.client.widgets.Canvas;
+import com.smartgwt.client.widgets.Label;
 import com.smartgwt.client.widgets.Window;
-import com.smartgwt.client.widgets.tab.TabSet;
-import com.smartgwt.client.widgets.tab.Tab;
-import com.smartgwt.client.widgets.layout.VLayout;
-import com.smartgwt.client.widgets.layout.HLayout;
-import com.smartgwt.client.widgets.Button;
-import com.smartgwt.client.widgets.Label;
-import com.smartgwt.client.widgets.Canvas;
-
+import com.smartgwt.client.widgets.events.ClickEvent;
+import com.smartgwt.client.widgets.events.ClickHandler;
 import com.smartgwt.client.widgets.form.DynamicForm;
+import com.smartgwt.client.widgets.form.fields.CheckboxItem;
 import com.smartgwt.client.widgets.form.fields.FormItem;
-import com.smartgwt.client.widgets.form.fields.CheckboxItem;
 import com.smartgwt.client.widgets.form.fields.SelectItem;
 import com.smartgwt.client.widgets.form.fields.TextItem;
-
-import com.smartgwt.client.widgets.events.ClickEvent;
-import com.smartgwt.client.widgets.events.ClickHandler;
+import com.smartgwt.client.widgets.form.fields.events.BlurEvent;
+import com.smartgwt.client.widgets.form.fields.events.BlurHandler;
+import com.smartgwt.client.widgets.form.fields.events.ChangedEvent;
 import com.smartgwt.client.widgets.form.fields.events.ChangedHandler;
-import com.smartgwt.client.widgets.form.fields.events.ChangedEvent;
-import com.smartgwt.client.widgets.form.fields.events.BlurHandler;
-import com.smartgwt.client.widgets.form.fields.events.BlurEvent;
-
-import com.smartgwt.client.types.Alignment;
+import com.smartgwt.client.widgets.layout.HLayout;
+import com.smartgwt.client.widgets.layout.VLayout;
+import com.smartgwt.client.widgets.tab.Tab;
+import com.smartgwt.client.widgets.tab.TabSet;
 
 import de.intevation.flys.client.client.Config;
 import de.intevation.flys.client.client.FLYSConstants;
+import de.intevation.flys.client.client.services.CollectionAttributeService;
+import de.intevation.flys.client.client.services.CollectionAttributeServiceAsync;
+import de.intevation.flys.client.client.utils.DoubleValidator;
+import de.intevation.flys.client.client.utils.IntegerValidator;
+import de.intevation.flys.client.shared.model.BooleanProperty;
+import de.intevation.flys.client.shared.model.Collection;
+import de.intevation.flys.client.shared.model.DoubleProperty;
+import de.intevation.flys.client.shared.model.IntegerProperty;
+import de.intevation.flys.client.shared.model.OutputSettings;
 import de.intevation.flys.client.shared.model.Property;
 import de.intevation.flys.client.shared.model.PropertyGroup;
 import de.intevation.flys.client.shared.model.PropertySetting;
-import de.intevation.flys.client.shared.model.BooleanProperty;
-import de.intevation.flys.client.shared.model.DoubleProperty;
-import de.intevation.flys.client.shared.model.IntegerProperty;
-import de.intevation.flys.client.shared.model.StringProperty;
 import de.intevation.flys.client.shared.model.Settings;
-import de.intevation.flys.client.shared.model.OutputSettings;
-import de.intevation.flys.client.shared.model.Collection;
-import de.intevation.flys.client.client.utils.IntegerValidator;
-import de.intevation.flys.client.client.utils.DoubleValidator;
+import de.intevation.flys.client.shared.model.StringProperty;
 
-import de.intevation.flys.client.client.services.CollectionAttributeService;
-import de.intevation.flys.client.client.services.CollectionAttributeServiceAsync;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
 
 /**
  * Dialog for the Chart-Properties, constructed from respective xml document.
@@ -102,7 +98,6 @@
         setCanDragReposition(true);
         setCanDragResize(true);
 
-        Config config = Config.getInstance();
         collection = tab.getCollectionView().getCollection();
         String outputName = tab.getOutputName();
         origSettings = (OutputSettings)collection.getSettings(outputName);
@@ -140,6 +135,7 @@
         Button cancel = new Button(MSG.label_cancel());
         cancel.addClickHandler(this);
         accept.addClickHandler(new ClickHandler() {
+            @Override
             public void onClick(ClickEvent e) {
                 if(isDialogValid()) {
                     updateCollection();
@@ -169,6 +165,7 @@
      * This method is called when the user aborts theming.
      * @param event The event.
      */
+    @Override
     public void onClick(ClickEvent event) {
         this.destroy();
     }
@@ -178,8 +175,6 @@
      *
      */
     protected Canvas generatePropertyGroup(Property group, Property orig) {
-        Config config = Config.getInstance();
-        String locale = config.getLocale();
         PropertyGroup pg = (PropertyGroup)group;
         PropertyGroup origPg = (PropertyGroup)orig;
 
@@ -230,6 +225,7 @@
                 origPg.getPropertyByName("fixation")).getValue().booleanValue());
 
             fix.addChangedHandler(new ChangedHandler() {
+                @Override
                 public void onChanged(ChangedEvent e) {
                     if ((Boolean)e.getValue()) {
                         range1.enable();
@@ -278,7 +274,6 @@
         Property setting,
         Property orig)
     {
-        PropertySetting s = (PropertySetting)setting;
         DynamicForm form = new DynamicForm();
         FormItem item = new FormItem();
         if (setting instanceof BooleanProperty) {
@@ -344,6 +339,7 @@
             logoChooser.setTitle(MSG.getString(name));
             logoChooser.setTitleAlign(Alignment.LEFT);
             logoChooser.addBlurHandler(new BlurHandler() {
+                @Override
                 public void onBlur(BlurEvent e) {
                     String val;
                     if (e.getItem().getValue() == null) {
@@ -369,6 +365,7 @@
             placeChooser.setTitle(MSG.getString(name));
             placeChooser.setTitleAlign(Alignment.LEFT);
             placeChooser.addBlurHandler(new BlurHandler() {
+                @Override
                 public void onBlur(BlurEvent e) {
                     String val;
                     if (e.getItem().getValue() == null) {
@@ -394,6 +391,7 @@
             placeChooser.setTitle(MSG.getString(name));
             placeChooser.setTitleAlign(Alignment.LEFT);
             placeChooser.addBlurHandler(new BlurHandler() {
+                @Override
                 public void onBlur(BlurEvent e) {
                     String val;
                     if (e.getItem().getValue() == null) {
@@ -412,6 +410,7 @@
         item.setTitle(MSG.getString(name));
         item.setTitleAlign(Alignment.LEFT);
         item.addBlurHandler(new BlurHandler() {
+            @Override
             public void onBlur(BlurEvent e) {
                 String val;
                 if (e.getItem().getValue() == null) {
@@ -441,6 +440,7 @@
         item.setTitleStyle("color:#000;");
         item.setTitleAlign(Alignment.LEFT);
         item.addBlurHandler(new BlurHandler() {
+            @Override
             public void onBlur(BlurEvent e) {
                 String val;
                 if (e.getItem().getValue() == null) {
@@ -469,6 +469,7 @@
         item.setTitle(MSG.getString(name));
         item.setTitleAlign(Alignment.LEFT);
         item.addBlurHandler(new BlurHandler() {
+            @Override
             public void onBlur(BlurEvent e) {
                  DoubleValidator validator = new DoubleValidator();
                  Map errors = e.getForm().getErrors();
@@ -495,6 +496,7 @@
         item.setTitle(MSG.getString(name));
         item.setTitleAlign(Alignment.LEFT);
         item.addBlurHandler(new BlurHandler() {
+            @Override
             public void onBlur(BlurEvent e) {
                 IntegerValidator validator = new IntegerValidator();
                 Map errors = e.getForm().getErrors();
@@ -517,10 +519,12 @@
         Settings s = settings;
         collection.addSettings(this.tab.getOutputName(), s);
         updater.update(collection, loc, new AsyncCallback<Collection>() {
+            @Override
             public void onFailure(Throwable caught) {
                 GWT.log("Could not update collection attributes.");
                 SC.warn(MSG.getString(caught.getMessage()));
             }
+            @Override
             public void onSuccess(Collection collection) {
                 updateChartTab();
             }

http://dive4elements.wald.intevation.org