diff flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ChartThemePanel.java @ 4568:bbd82bd8e541

flys-client: Cosmetics and warnings.
author Christian Lins <christian.lins@intevation.de>
date Mon, 19 Nov 2012 00:07:53 +0100
parents 51ed89b754ae
children
line wrap: on
line diff
--- a/flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ChartThemePanel.java	Sun Nov 18 01:19:07 2012 +0100
+++ b/flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ChartThemePanel.java	Mon Nov 19 00:07:53 2012 +0100
@@ -1,43 +1,35 @@
 package de.intevation.flys.client.client.ui.chart;
 
 import com.google.gwt.core.client.GWT;
-
 import com.google.gwt.user.client.rpc.AsyncCallback;
 
 import com.smartgwt.client.types.ListGridFieldType;
-
+import com.smartgwt.client.util.SC;
 import com.smartgwt.client.widgets.grid.ListGridField;
 import com.smartgwt.client.widgets.grid.ListGridRecord;
 import com.smartgwt.client.widgets.layout.VLayout;
-import com.smartgwt.client.widgets.menu.events.ClickHandler;
-
 import com.smartgwt.client.widgets.menu.Menu;
 import com.smartgwt.client.widgets.menu.MenuItem;
+import com.smartgwt.client.widgets.menu.events.ClickHandler;
 import com.smartgwt.client.widgets.menu.events.MenuItemClickEvent;
 
-import com.smartgwt.client.util.SC;
-
+import de.intevation.flys.client.client.Config;
+import de.intevation.flys.client.client.FLYSConstants;
+import de.intevation.flys.client.client.services.FeedServiceAsync;
+import de.intevation.flys.client.client.services.LoadArtifactService;
+import de.intevation.flys.client.client.services.LoadArtifactServiceAsync;
+import de.intevation.flys.client.client.ui.CollectionView;
+import de.intevation.flys.client.client.ui.ThemePanel;
 import de.intevation.flys.client.shared.model.Artifact;
 import de.intevation.flys.client.shared.model.Data;
+import de.intevation.flys.client.shared.model.DefaultArtifact;
 import de.intevation.flys.client.shared.model.DefaultData;
-import de.intevation.flys.client.shared.model.DefaultArtifact;
 import de.intevation.flys.client.shared.model.FacetRecord;
 import de.intevation.flys.client.shared.model.OutputMode;
 import de.intevation.flys.client.shared.model.Recommendation;
 import de.intevation.flys.client.shared.model.Theme;
 import de.intevation.flys.client.shared.model.ThemeList;
 
-import de.intevation.flys.client.client.Config;
-import de.intevation.flys.client.client.FLYSConstants;
-import de.intevation.flys.client.client.ui.CollectionView;
-import de.intevation.flys.client.client.ui.ThemePanel;
-
-import de.intevation.flys.client.client.services.FeedService;
-import de.intevation.flys.client.client.services.FeedServiceAsync;
-
-import de.intevation.flys.client.client.services.LoadArtifactService;
-import de.intevation.flys.client.client.services.LoadArtifactServiceAsync;
-
 
 /**
  * ThemePanel on the left in CollectionView.
@@ -208,12 +200,14 @@
             new DefaultArtifact(artifact, "TODO:hash"),
             feedData,
             new AsyncCallback<Artifact>() {
+                @Override
                 public void onFailure(Throwable caught) {
                     GWT.log("Could not feed artifact (" + artifact
                             + ") with area info: " + caught.getMessage());
                     SC.warn(MSG.getString(caught.getMessage()));
                     enable();
                 }
+                @Override
                 public void onSuccess(Artifact fartifact) {
                     GWT.log("Successfully set area params to " + artifact);
                     requestRedraw();
@@ -252,11 +246,14 @@
             null, //use individual factories.
             locale,
             new AsyncCallback<Artifact[]>() {
+                @Override
                 public void onFailure(Throwable caught) {
                     GWT.log("Failed, no area artifact: " + caught.getMessage());
                     enable();
-                    // TODO SC.warn
+                    // TODO i18n
+                    SC.warn("Failed, no area artifact: " + caught.getMessage());
                 }
+                @Override
                 public void onSuccess(Artifact[] artifacts) {
                     GWT.log("Success, created area artifact: "
                         + artifacts[0].getUuid());
@@ -307,6 +304,7 @@
         MenuItem editManualPoints = new MenuItem(MSG.editpoints());
 
         editManualPoints.addClickHandler(new ClickHandler() {
+                @Override
                 public void onClick(MenuItemClickEvent evt) {
                     if(mode.getName().equals("historical_discharge")) {
                         new ManualDatePointsEditor(view.getCollection(),
@@ -328,11 +326,12 @@
      * Include area specific menu items and manual point editor, depending
      * on facet.
      */
+    @Override
     protected Menu getSingleContextMenu(final ListGridRecord[] records) {
         Menu menu = super.getSingleContextMenu(records);
 
         final Theme facetTheme = ((FacetRecord)records[0]).getTheme();
-        String thisItem = facetTheme.getDescription();
+
         if (!canArea(facetTheme)) {
             if (facetTheme.getFacet().endsWith("manualpoints")) {
                 attachManualPointsMenu(menu);
@@ -369,6 +368,7 @@
             underMenu.addItem(againster);
 
             againster.addClickHandler(new ClickHandler() {
+                @Override
                 public void onClick(MenuItemClickEvent evt) {
                     disable();
                     createAreaArtifact(theme, facetTheme, false);
@@ -391,6 +391,7 @@
             overMenu.addItem(againster);
 
             againster.addClickHandler(new ClickHandler() {
+                @Override
                 public void onClick(MenuItemClickEvent evt) {
                     disable();
                     createAreaArtifact(facetTheme, theme, false);
@@ -400,6 +401,7 @@
         overMenu.addItem(createSeparator());
         MenuItem againstAxis = new MenuItem(MSG.getString("x_axis"));
         againstAxis.addClickHandler(new ClickHandler() {
+            @Override
             public void onClick(MenuItemClickEvent evt) {
                 disable();
                 createAreaArtifact(null, facetTheme, false);
@@ -422,6 +424,7 @@
             betweenMenu.addItem(againster);
 
             againster.addClickHandler(new ClickHandler() {
+                @Override
                 public void onClick(MenuItemClickEvent evt) {
                     disable();
                     createAreaArtifact(facetTheme, theme, true);
@@ -441,6 +444,7 @@
         areaMenu.addItem(createSeparator());
         MenuItem standAloneAgainstAxis = new MenuItem(MSG.getString("against_x_axis"));
         standAloneAgainstAxis.addClickHandler(new ClickHandler() {
+            @Override
             public void onClick(MenuItemClickEvent evt) {
                 disable();
                 createAreaArtifact(null, facetTheme, false);

http://dive4elements.wald.intevation.org