diff flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ManualDatePointsEditor.java @ 4568:bbd82bd8e541

flys-client: Cosmetics and warnings.
author Christian Lins <christian.lins@intevation.de>
date Mon, 19 Nov 2012 00:07:53 +0100
parents 51ed89b754ae
children e70ff0a600a3
line wrap: on
line diff
--- a/flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ManualDatePointsEditor.java	Sun Nov 18 01:19:07 2012 +0100
+++ b/flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ManualDatePointsEditor.java	Mon Nov 19 00:07:53 2012 +0100
@@ -1,47 +1,42 @@
 package de.intevation.flys.client.client.ui.chart;
 
-import java.util.List;
-import java.util.Date;
-
+import com.google.gwt.core.client.GWT;
+import com.google.gwt.i18n.client.DateTimeFormat;
+import com.google.gwt.i18n.client.NumberFormat;
 import com.google.gwt.json.client.JSONArray;
 import com.google.gwt.json.client.JSONBoolean;
 import com.google.gwt.json.client.JSONNumber;
 import com.google.gwt.json.client.JSONParser;
 import com.google.gwt.json.client.JSONString;
-import com.google.gwt.core.client.GWT;
-import com.google.gwt.i18n.client.DateTimeFormat;
 
+import com.smartgwt.client.types.Alignment;
+import com.smartgwt.client.types.ListGridFieldType;
 import com.smartgwt.client.util.SC;
-import com.smartgwt.client.widgets.layout.VLayout;
-import com.smartgwt.client.widgets.layout.HLayout;
+import com.smartgwt.client.widgets.Button;
 import com.smartgwt.client.widgets.IButton;
-import com.smartgwt.client.widgets.Button;
+import com.smartgwt.client.widgets.events.ClickEvent;
+import com.smartgwt.client.widgets.events.ClickHandler;
+import com.smartgwt.client.widgets.grid.CellEditValueFormatter;
+import com.smartgwt.client.widgets.grid.CellEditValueParser;
+import com.smartgwt.client.widgets.grid.CellFormatter;
 import com.smartgwt.client.widgets.grid.ListGrid;
 import com.smartgwt.client.widgets.grid.ListGridField;
 import com.smartgwt.client.widgets.grid.ListGridRecord;
 import com.smartgwt.client.widgets.grid.events.RecordClickEvent;
 import com.smartgwt.client.widgets.grid.events.RecordClickHandler;
-import com.smartgwt.client.types.ListGridFieldType;
-import com.smartgwt.client.widgets.grid.CellFormatter;
-import com.google.gwt.i18n.client.NumberFormat;
+import com.smartgwt.client.widgets.layout.HLayout;
+import com.smartgwt.client.widgets.layout.VLayout;
 
-import com.smartgwt.client.widgets.grid.CellEditValueParser;
-import com.smartgwt.client.widgets.grid.CellEditValueFormatter;
-import com.smartgwt.client.widgets.events.ClickEvent;
-import com.smartgwt.client.widgets.events.ClickHandler;
-
-import com.smartgwt.client.types.Alignment;
-
-import de.intevation.flys.client.client.Config;
+import de.intevation.flys.client.client.event.RedrawRequestHandler;
 import de.intevation.flys.client.shared.model.Collection;
 import de.intevation.flys.client.shared.model.CollectionItem;
-
-import de.intevation.flys.client.shared.model.Settings;
 import de.intevation.flys.client.shared.model.Property;
 import de.intevation.flys.client.shared.model.PropertyGroup;
+import de.intevation.flys.client.shared.model.Settings;
 import de.intevation.flys.client.shared.model.StringProperty;
 
-import de.intevation.flys.client.client.event.RedrawRequestHandler;
+import java.util.Date;
+import java.util.List;
 
 /**
  * UI to enter point data and save it to an PointArtifact.
@@ -58,14 +53,14 @@
 
 
     /** Create and setup/add the ui. */
+    @Override
     public void createUI() {
-        Config config = Config.getInstance();
-
         Button accept = new Button(MSG.label_ok());
         Button cancel = new Button(MSG.label_cancel());
         cancel.addClickHandler(this);
 
         accept.addClickHandler(new ClickHandler() {
+            @Override
             public void onClick(ClickEvent e) {
                 okClicked();
             }
@@ -86,6 +81,7 @@
         listGrid.setShowHeaderContextMenu(false);
 
         CellFormatter doubleFormat = new CellFormatter() {
+            @Override
             public String format(Object value, ListGridRecord record, int rowNum, int colNum) {
                 if(value != null) {
                     NumberFormat nf = NumberFormat.getDecimalFormat();
@@ -101,6 +97,7 @@
             }};
 
         CellFormatter dateFormat = new CellFormatter() {
+            @Override
             public String format(Object value, ListGridRecord record, int rowNum, int colNum) {
                 if(value != null && !value.toString().equals("")) {
                     try {
@@ -126,6 +123,7 @@
 
 
         CellEditValueParser cevp = new CellEditValueParser() {
+            @Override
             public Object parse(Object value, ListGridRecord record, int rowNum, int colNum) {
                 if (value == null)
                     return null;
@@ -141,6 +139,7 @@
         };
 
         CellEditValueFormatter cevf = new CellEditValueFormatter() {
+            @Override
             public Object format(Object value, ListGridRecord record, int rowNum, int colNum) {
                 if (value != null) {
                     NumberFormat nf = NumberFormat.getDecimalFormat();
@@ -214,6 +213,7 @@
             nameField, removeField});
 
         listGrid.addRecordClickHandler(new RecordClickHandler() {
+                @Override
                 public void onRecordClick(final RecordClickEvent event) {
                     // Just handle remove-clicks
                     if(!event.getField().getName().equals(removeField.getName())) {
@@ -237,13 +237,13 @@
             }
         }
         else {
-            // TODO proper log
-            System.out.println("No item found for " + uuid);
+            GWT.log("No item found for " + uuid);
         }
 
         IButton button = new IButton(MSG.newpoint());
         button.setTop(250);
         button.addClickHandler(new ClickHandler() {
+            @Override
             public void onClick(ClickEvent event) {
                 listGrid.startEditingNew();
             }
@@ -262,6 +262,7 @@
 
 
     /** Create JSON representation of the points present in the list grid. */
+    @Override
     protected JSONArray jsonArrayFromListGrid() {
         JSONArray list = new JSONArray();
         int idx = 0;
@@ -276,7 +277,7 @@
                     DateTimeFormat.PredefinedFormat.DATE_MEDIUM);
 
                 Date d = df.parse(dateString);
-                double dv = (double)d.getTime();
+                double dv = d.getTime();
 
                 data.set(0, new JSONNumber(dv));
                 data.set(1, new JSONNumber(point.getY()));
@@ -304,7 +305,7 @@
                     DateTimeFormat.PredefinedFormat.DATE_MEDIUM);
 
                 Date d = df.parse(dateString);
-                double dv = (double)d.getTime();
+                double dv = d.getTime();
                 data.set(0, new JSONNumber(dv));
                 data.set(1, new JSONNumber(record.
                     getAttributeAsDouble(PointRecord.ATTRIBUTE_Y)));

http://dive4elements.wald.intevation.org