diff artifacts/src/main/java/org/dive4elements/river/artifacts/uinfo/CalculationSelectUinfo.java @ 9184:dace17e26d33

code review uinfo.inundationduration
author gernotbelger
date Wed, 27 Jun 2018 14:07:02 +0200
parents 2f5052835b76
children f692f5a0536a
line wrap: on
line diff
--- a/artifacts/src/main/java/org/dive4elements/river/artifacts/uinfo/CalculationSelectUinfo.java	Tue Jun 26 20:19:31 2018 +0200
+++ b/artifacts/src/main/java/org/dive4elements/river/artifacts/uinfo/CalculationSelectUinfo.java	Wed Jun 27 14:07:02 2018 +0200
@@ -53,10 +53,11 @@
     @Override
     public boolean validate(final Artifact artifact) throws IllegalArgumentException {
         log.debug("CalculationSelect.validate");
+        /* throws an exception if calculation mode is invalid */
 
         final UINFOArtifact uinfo = (UINFOArtifact) artifact;
-        final String calcDebug = uinfo.getCalculationMode().toString();
-        if (calcDebug.equals("uinfo_inundation_duration")) {
+        final String calcmode = uinfo.getCalculationMode().toString(); // "toString()" is important
+        if (calcmode.equals("uinfo_inundation_duration")) {
 
             final String river = uinfo.getRiver();
             if (!UedauernPropertiesHelper.fileExistsForRiver(river)) {
@@ -64,8 +65,6 @@
             }
         }
 
-        /* throws an exception if calculation mode is invalid */
-
         return true;
     }
 }
\ No newline at end of file

http://dive4elements.wald.intevation.org