Mercurial > dive4elements > river
diff backend/src/main/java/org/dive4elements/river/backend/SessionHolder.java @ 8566:fe7e9da6312a
(issue1797) Move close into session release and guard it.
To avoid leaking open and Held sessions we centrally close
the session in the SessionHolder on release.
This also removes some duplicated code in SedDBSessionHolder
author | Andre Heinecke <andre.heinecke@intevation.de> |
---|---|
date | Tue, 24 Feb 2015 17:16:14 +0100 |
parents | 4c3ccf2b0304 |
children | 9bbce0edd36b |
line wrap: on
line diff
--- a/backend/src/main/java/org/dive4elements/river/backend/SessionHolder.java Tue Feb 17 13:58:23 2015 +0100 +++ b/backend/src/main/java/org/dive4elements/river/backend/SessionHolder.java Tue Feb 24 17:16:14 2015 +0100 @@ -27,7 +27,7 @@ } }; - private SessionHolder() { + protected SessionHolder() { } public synchronized static Session create() { @@ -46,6 +46,24 @@ public static void release() { log.debug("release"); + Session session = HOLDER.get(); + if (session != null) { + try { + if (!session.isOpen()) { + /* If this check really works in all cases why does hibernate + * does not use it when you call close anyway. */ + log.debug("Session is not open. Calling close anyway."); + } + session.close(); + } catch (Exception e) { + /* Do not try this at home. But hibernate may fail with an NPE + * or any other exception depending on the state of the session. + * According to doc this should only throw a HibernateException but + * we definetely get NPE's here. + */ + log.error("Exception caught on session close! Session already closed?" + e.getMessage()); + } + } HOLDER.remove(); } }