Mercurial > dive4elements > river
view flys-client/src/main/java/de/intevation/flys/client/server/AdvanceServiceImpl.java @ 4488:5041105d2edd
Check if response code from GGInA is 200 OK
Only parse the GGInA response if the status code is 200 OK. This improves the
error message if GGInA is not available and shows the real reason instead of a
JDOM error while parsing the response.
author | Björn Ricks <bjoern.ricks@intevation.de> |
---|---|
date | Wed, 14 Nov 2012 10:36:21 +0100 |
parents | f2039d030b5e |
children |
line wrap: on
line source
package de.intevation.flys.client.server; import org.w3c.dom.Document; import org.apache.log4j.Logger; import com.google.gwt.user.server.rpc.RemoteServiceServlet; import de.intevation.artifacts.common.ArtifactNamespaceContext; import de.intevation.artifacts.common.utils.ClientProtocolUtils; import de.intevation.artifacts.common.utils.XMLUtils; import de.intevation.artifacts.httpclient.exceptions.ConnectionException; import de.intevation.artifacts.httpclient.http.HttpClient; import de.intevation.artifacts.httpclient.http.HttpClientImpl; import de.intevation.artifacts.httpclient.http.response.DocumentResponseHandler; import de.intevation.flys.client.shared.exceptions.ServerException; import de.intevation.flys.client.shared.model.Artifact; import de.intevation.flys.client.client.services.AdvanceService; /** * This interface provides artifact specific operation ADVANCE. * * @author <a href="mailto:ingo.weinzierl@intevation.de">Ingo Weinzierl</a> */ public class AdvanceServiceImpl extends RemoteServiceServlet implements AdvanceService { private static final Logger logger = Logger.getLogger(AdvanceService.class); public static final String XPATH_RESULT = "/art:result/text()"; public static final String OPERATION_FAILURE = "FAILED"; public static final String ERROR_ADVANCE_ARTIFACT = "error_advance_artifact"; public Artifact advance( String locale, Artifact artifact, String target) throws ServerException { logger.info("AdvanceServiceImpl.advance"); String url = getServletContext().getInitParameter("server-url"); Document advance = ClientProtocolUtils.newAdvanceDocument( artifact.getUuid(), artifact.getHash(), target); HttpClient client = new HttpClientImpl(url, locale); try { Document description = (Document) client.advance( new de.intevation.artifacts.httpclient.objects.Artifact( artifact.getUuid(), artifact.getHash()), advance, new DocumentResponseHandler()); if (description == null) { throw new ServerException(ERROR_ADVANCE_ARTIFACT); } String result = XMLUtils.xpathString( description, XPATH_RESULT, ArtifactNamespaceContext.INSTANCE); if (result == null || !result.equals(OPERATION_FAILURE)) { return (Artifact) new FLYSArtifactCreator().create(description); } } catch (ConnectionException ce) { logger.error(ce, ce); } throw new ServerException(ERROR_ADVANCE_ARTIFACT); } } // vim:set ts=4 sw=4 si et sta sts=4 fenc=utf8 :