view flys-client/src/main/java/de/intevation/flys/client/server/AdvanceServiceImpl.java @ 5779:ebec12def170

Datacage: Add a pool of builders to make it multi threadable. XML DOM is not thread safe. Therefore the old implementation only allowed one thread to use the builder at a time. As the complexity of the configuration has increased over time this has become a bottleneck of the whole application because it took quiet some time to build a result. Furthermore the builder code path is visited very frequent. So many concurrent requests were piled up resulting in long waits for the users. To mitigate this problem a round robin pool of builders is used now. Each of the pooled builders has an independent copy of the XML template and can be run in parallel. The number of builders is determined by the system property 'flys.datacage.pool.size'. It defaults to 4.
author Sascha L. Teichmann <teichmann@intevation.de>
date Sun, 21 Apr 2013 12:48:09 +0200
parents f2039d030b5e
children
line wrap: on
line source
package de.intevation.flys.client.server;

import org.w3c.dom.Document;

import org.apache.log4j.Logger;

import com.google.gwt.user.server.rpc.RemoteServiceServlet;

import de.intevation.artifacts.common.ArtifactNamespaceContext;
import de.intevation.artifacts.common.utils.ClientProtocolUtils;
import de.intevation.artifacts.common.utils.XMLUtils;

import de.intevation.artifacts.httpclient.exceptions.ConnectionException;
import de.intevation.artifacts.httpclient.http.HttpClient;
import de.intevation.artifacts.httpclient.http.HttpClientImpl;
import de.intevation.artifacts.httpclient.http.response.DocumentResponseHandler;

import de.intevation.flys.client.shared.exceptions.ServerException;
import de.intevation.flys.client.shared.model.Artifact;
import de.intevation.flys.client.client.services.AdvanceService;


/**
 * This interface provides artifact specific operation ADVANCE.
 *
 * @author <a href="mailto:ingo.weinzierl@intevation.de">Ingo Weinzierl</a>
 */
public class AdvanceServiceImpl
extends      RemoteServiceServlet
implements   AdvanceService
{
    private static final Logger logger = Logger.getLogger(AdvanceService.class);

    public static final String XPATH_RESULT = "/art:result/text()";

    public static final String OPERATION_FAILURE = "FAILED";

    public static final String ERROR_ADVANCE_ARTIFACT = "error_advance_artifact";


    public Artifact advance(
        String   locale,
        Artifact artifact,
        String   target)
    throws ServerException
    {
        logger.info("AdvanceServiceImpl.advance");

        String url = getServletContext().getInitParameter("server-url");

        Document advance = ClientProtocolUtils.newAdvanceDocument(
            artifact.getUuid(),
            artifact.getHash(),
            target);

        HttpClient client = new HttpClientImpl(url, locale);

        try {
            Document description = (Document) client.advance(
                new de.intevation.artifacts.httpclient.objects.Artifact(
                    artifact.getUuid(),
                    artifact.getHash()),
                advance,
                new DocumentResponseHandler());

            if (description == null) {
                throw new ServerException(ERROR_ADVANCE_ARTIFACT);
            }

            String result = XMLUtils.xpathString(
                description,
                XPATH_RESULT,
                ArtifactNamespaceContext.INSTANCE);

            if (result == null || !result.equals(OPERATION_FAILURE)) {
                return (Artifact) new FLYSArtifactCreator().create(description);
            }
        }
        catch (ConnectionException ce) {
            logger.error(ce, ce);
        }

        throw new ServerException(ERROR_ADVANCE_ARTIFACT);
    }
}
// vim:set ts=4 sw=4 si et sta sts=4 fenc=utf8 :

http://dive4elements.wald.intevation.org