Mercurial > dive4elements > river
view flys-client/src/main/java/de/intevation/flys/client/server/DoCollectionAction.java @ 5779:ebec12def170
Datacage: Add a pool of builders to make it multi threadable.
XML DOM is not thread safe. Therefore the old implementation only allowed one thread
to use the builder at a time. As the complexity of the configuration
has increased over time this has become a bottleneck of the whole application
because it took quiet some time to build a result. Furthermore the builder code path
is visited very frequent. So many concurrent requests were piled up
resulting in long waits for the users.
To mitigate this problem a round robin pool of builders is used now.
Each of the pooled builders has an independent copy of the XML template
and can be run in parallel.
The number of builders is determined by the system property
'flys.datacage.pool.size'. It defaults to 4.
author | Sascha L. Teichmann <teichmann@intevation.de> |
---|---|
date | Sun, 21 Apr 2013 12:48:09 +0200 |
parents | ab8eb2f544f2 |
children |
line wrap: on
line source
package de.intevation.flys.client.server; import org.w3c.dom.Document; import org.apache.log4j.Logger; import com.google.gwt.user.server.rpc.RemoteServiceServlet; import de.intevation.artifacts.common.ArtifactNamespaceContext; import de.intevation.artifacts.common.utils.XMLUtils; import de.intevation.artifacts.httpclient.exceptions.ConnectionException; import de.intevation.artifacts.httpclient.http.HttpClient; import de.intevation.artifacts.httpclient.http.HttpClientImpl; import de.intevation.artifacts.httpclient.http.response.DocumentResponseHandler; import de.intevation.flys.client.shared.exceptions.ServerException; import de.intevation.flys.client.shared.model.Collection; /** * @author <a href="mailto:ingo.weinzierl@intevation.de">Ingo Weinzierl</a> */ public class DoCollectionAction extends RemoteServiceServlet { private static final Logger logger = Logger.getLogger(DoCollectionAction.class); public static final String XPATH_RESULT = "/art:result/text()"; public static final String OPERATION_FAILURE = "FAILED"; public static final String FAILURE_EXCEPTION = "collection_action_failed"; protected void doAction(Collection c, Document action, String url) throws ServerException { logger.info("DoCollectionAction.doAction"); HttpClient client = new HttpClientImpl(url); try { Document res = (Document) client.doCollectionAction( action, c.identifier(), new DocumentResponseHandler()); String result = XMLUtils.xpathString( res, XPATH_RESULT, ArtifactNamespaceContext.INSTANCE); if (result == null || result.equals(OPERATION_FAILURE)) { logger.error("Operation failed."); throw new ServerException(FAILURE_EXCEPTION); } } catch (ConnectionException ce) { logger.error(ce, ce); throw new ServerException(FAILURE_EXCEPTION); } } }