Mercurial > dive4elements > river
view flys-client/src/main/java/de/intevation/flys/client/server/ModuleServiceImpl.java @ 5779:ebec12def170
Datacage: Add a pool of builders to make it multi threadable.
XML DOM is not thread safe. Therefore the old implementation only allowed one thread
to use the builder at a time. As the complexity of the configuration
has increased over time this has become a bottleneck of the whole application
because it took quiet some time to build a result. Furthermore the builder code path
is visited very frequent. So many concurrent requests were piled up
resulting in long waits for the users.
To mitigate this problem a round robin pool of builders is used now.
Each of the pooled builders has an independent copy of the XML template
and can be run in parallel.
The number of builders is determined by the system property
'flys.datacage.pool.size'. It defaults to 4.
author | Sascha L. Teichmann <teichmann@intevation.de> |
---|---|
date | Sun, 21 Apr 2013 12:48:09 +0200 |
parents | fed914a42a10 |
children |
line wrap: on
line source
package de.intevation.flys.client.server; import de.intevation.artifacts.common.ArtifactNamespaceContext; import de.intevation.artifacts.common.utils.XMLUtils; import de.intevation.artifacts.httpclient.exceptions.ConnectionException; import de.intevation.artifacts.httpclient.http.HttpClient; import de.intevation.artifacts.httpclient.http.HttpClientImpl; import de.intevation.flys.client.client.services.ModuleService; import de.intevation.flys.client.server.auth.User; import de.intevation.flys.client.shared.exceptions.ServerException; import de.intevation.flys.client.shared.model.DefaultModule; import de.intevation.flys.client.shared.model.Module; import java.util.ArrayList; import java.util.List; import javax.xml.xpath.XPathConstants; import org.apache.log4j.Logger; import org.w3c.dom.Document; import org.w3c.dom.Element; import org.w3c.dom.NodeList; public class ModuleServiceImpl extends RemoteServiceServlet implements ModuleService { private static final Logger logger = Logger.getLogger(ModuleServiceImpl.class); public static final String XPATH_MODULES = "/art:modules/art:module"; public static final String ERROR_NO_MODULES_FOUND = "error_no_module_found"; @Override public Module[] list(String locale) throws ServerException { User user = this.getUser(); logger.info("ModuleService.list"); String url = getServletContext().getInitParameter("server-url"); // create dummy xml Document doc = XMLUtils.newDocument(); XMLUtils.ElementCreator ec = new XMLUtils.ElementCreator( doc, ArtifactNamespaceContext.NAMESPACE_URI, ArtifactNamespaceContext.NAMESPACE_PREFIX); Element dummy = ec.create("modules"); doc.appendChild(dummy); HttpClient client = new HttpClientImpl(url, locale); try { Document result = client.callService(url, "modules", doc); NodeList list = (NodeList) XMLUtils.xpath( result, XPATH_MODULES, XPathConstants.NODESET, ArtifactNamespaceContext.INSTANCE); if (list == null) { logger.warn("No modules found."); throw new ServerException(ERROR_NO_MODULES_FOUND); } int num = list.getLength(); List<Module> modules = new ArrayList<Module>(list.getLength()); for(int i =0; i < num; i++) { Element em = (Element)list.item(i); String name = em.getAttributeNS( ArtifactNamespaceContext.NAMESPACE_URI, "name"); String localname = em.getAttributeNS( ArtifactNamespaceContext.NAMESPACE_URI, "localname"); String strselected = em.getAttributeNS( ArtifactNamespaceContext.NAMESPACE_URI, "selected"); boolean selected = strselected == null ? false : strselected.equalsIgnoreCase("true"); logger.debug("Found module " + name + " " + localname); if (user == null || user.canUseFeature("module:" + name)) { modules.add(new DefaultModule(name, localname, selected)); } } return modules.toArray(new Module[modules.size()]); } catch (ConnectionException ce) { logger.error(ce, ce); } throw new ServerException(ERROR_NO_MODULES_FOUND); } } // vim:set ts=4 sw=4 si et sta sts=4 fenc=utf8 tw=80 :