# HG changeset patch # User Ingo Weinzierl # Date 1327670317 0 # Node ID 19518116a49a7e47be16def32870f71491c77ac6 # Parent fd9aece97aa34e9347b0eddc1dfa0137e8eda8ed Refactored some code in DefaultState to better override the base class. flys-artifacts/trunk@3799 c6561f87-3c4e-4783-a992-168aeb5c3f6f diff -r fd9aece97aa3 -r 19518116a49a flys-artifacts/ChangeLog --- a/flys-artifacts/ChangeLog Fri Jan 27 13:12:31 2012 +0000 +++ b/flys-artifacts/ChangeLog Fri Jan 27 13:18:37 2012 +0000 @@ -1,3 +1,8 @@ +2012-01-27 Ingo Weinzierl + + * src/main/java/de/intevation/flys/artifacts/states/DefaultState.java: Moved + code to add items to a data node for dynamich UI into an own method. + 2012-01-27 Ingo Weinzierl * src/main/java/de/intevation/flys/artifacts/model/WQKmsFacet.java: Removed diff -r fd9aece97aa3 -r 19518116a49a flys-artifacts/src/main/java/de/intevation/flys/artifacts/states/DefaultState.java --- a/flys-artifacts/src/main/java/de/intevation/flys/artifacts/states/DefaultState.java Fri Jan 27 13:12:31 2012 +0000 +++ b/flys-artifacts/src/main/java/de/intevation/flys/artifacts/states/DefaultState.java Fri Jan 27 13:18:37 2012 +0000 @@ -228,18 +228,8 @@ } } - Element choices = ProtocolUtils.createArtNode( - creator, "choices", null, null); - - select.appendChild(choices); + appendItems(artifact, creator, name, context, select); ui.appendChild(select); - - Element[] items = createItems(creator, artifact, name, context); - if (items != null) { - for (Element item: items) { - choices.appendChild(item); - } - } } return ui; @@ -247,6 +237,34 @@ /** + * @param artifact + * @param creator + * @param name + * @param context + * @param select + */ + protected void appendItems( + Artifact artifact, + ElementCreator creator, + String name, + CallContext context, + Element select + ) { + Element choices = ProtocolUtils.createArtNode( + creator, "choices", null, null); + + select.appendChild(choices); + + Element[] items = createItems(creator, artifact, name, context); + if (items != null) { + for (Element item: items) { + choices.appendChild(item); + } + } + } + + + /** * This method creates the root node that contains the list of selectable * items. *