# HG changeset patch # User Felix Wolfsteller # Date 1321366531 0 # Node ID 9144e5a5027bcd7412853772b55fb2b945823142 # Parent ad22fc70bdab83a5fe2ac319919b4a85499e5eb6 (Picky) cosmetics. flys-artifacts/trunk@3250 c6561f87-3c4e-4783-a992-168aeb5c3f6f diff -r ad22fc70bdab -r 9144e5a5027b flys-artifacts/ChangeLog --- a/flys-artifacts/ChangeLog Tue Nov 15 14:10:21 2011 +0000 +++ b/flys-artifacts/ChangeLog Tue Nov 15 14:15:31 2011 +0000 @@ -1,3 +1,13 @@ +2011-11-15 Felix Wolfsteller + + Picky cosmetics. + + * src/main/java/de/intevation/flys/artifacts/model/QRangeTree.java, + src/main/java/de/intevation/flys/artifacts/model/ManagedFacetAdapter.java, + src/main/java/de/intevation/flys/artifacts/datacage/templating/Builder.java, + src/main/java/de/intevation/flys/artifacts/states/ComputationRangeState.java: + Cosmetics, docs. + 2011-11-15 Felix Wolfsteller Added translations for Mosel, Elbe and Saar. diff -r ad22fc70bdab -r 9144e5a5027b flys-artifacts/src/main/java/de/intevation/flys/artifacts/datacage/templating/Builder.java --- a/flys-artifacts/src/main/java/de/intevation/flys/artifacts/datacage/templating/Builder.java Tue Nov 15 14:10:21 2011 +0000 +++ b/flys-artifacts/src/main/java/de/intevation/flys/artifacts/datacage/templating/Builder.java Tue Nov 15 14:15:31 2011 +0000 @@ -130,6 +130,9 @@ statements.clear(); } + /** + * Handle a \ node. + */ protected void context(Node parent, Element current) throws SQLException { @@ -144,7 +147,7 @@ Node node = subs.item(i); String ns; if (node.getNodeType() == Node.ELEMENT_NODE - && node.getLocalName().equals("statement") + && node.getLocalName().equals("statement") && (ns = node.getNamespaceURI()) != null && ns.equals(DC_NAMESPACE_URI)) { stmntNode = node; @@ -157,10 +160,10 @@ return; } + String stmntText = stmntNode.getTextContent(); + String con = current.getAttribute("connection"); - String stmntText = stmntNode.getTextContent(); - String key = con + "-" + stmntText; CompiledStatement.Instance csi = statements.get(key); @@ -203,6 +206,9 @@ } } + /** + * Kind of foreach over results of a statement within a context. + */ protected void elements(Node parent, Element current) throws SQLException { @@ -247,6 +253,9 @@ } } + /** + * Create element. + */ protected void element(Node parent, Element current) throws SQLException { @@ -279,7 +288,10 @@ parent.appendChild(owner.createTextNode(value)); } - + /** + * Add attribute to an element + * @see element + */ protected void attribute(Node parent, Element current) { if (parent.getNodeType() != Node.ELEMENT_NODE) { @@ -309,7 +321,7 @@ DC_NAMESPACE_URI, "macro"); for (int i = 0, N = macros.getLength(); i < N; ++i) { - Element macro = (Element)macros.item(i); + Element macro = (Element) macros.item(i); if (name.equals(macro.getAttribute("name"))) { NodeList subs = macro.getChildNodes(); for (int j = 0, M = subs.getLength(); j < M; ++j) { diff -r ad22fc70bdab -r 9144e5a5027b flys-artifacts/src/main/java/de/intevation/flys/artifacts/model/ManagedFacetAdapter.java --- a/flys-artifacts/src/main/java/de/intevation/flys/artifacts/model/ManagedFacetAdapter.java Tue Nov 15 14:10:21 2011 +0000 +++ b/flys-artifacts/src/main/java/de/intevation/flys/artifacts/model/ManagedFacetAdapter.java Tue Nov 15 14:15:31 2011 +0000 @@ -1,5 +1,7 @@ package de.intevation.flys.artifacts.model; +import org.apache.log4j.Logger; + import org.w3c.dom.Document; import org.w3c.dom.Element; import org.w3c.dom.Node; @@ -19,6 +21,9 @@ public ManagedFacetAdapter() { } + + protected Logger logger = Logger.getLogger(ManagedFacetAdapter.class); + public ManagedFacetAdapter( Facet facet, String uuid, diff -r ad22fc70bdab -r 9144e5a5027b flys-artifacts/src/main/java/de/intevation/flys/artifacts/model/QRangeTree.java --- a/flys-artifacts/src/main/java/de/intevation/flys/artifacts/model/QRangeTree.java Tue Nov 15 14:10:21 2011 +0000 +++ b/flys-artifacts/src/main/java/de/intevation/flys/artifacts/model/QRangeTree.java Tue Nov 15 14:15:31 2011 +0000 @@ -114,7 +114,7 @@ Node [] nodes = new Node[stop-start]; for (int i = 0; i < nodes.length; ++i) { - Object [] qRange = qRanges.get(i + start); + Object [] qRange = qRanges.get(start + i); Double q = (Double)qRange[1]; Double a = (Double)qRange[2]; Double b = (Double)qRange[3]; diff -r ad22fc70bdab -r 9144e5a5027b flys-artifacts/src/main/java/de/intevation/flys/artifacts/states/ComputationRangeState.java --- a/flys-artifacts/src/main/java/de/intevation/flys/artifacts/states/ComputationRangeState.java Tue Nov 15 14:10:21 2011 +0000 +++ b/flys-artifacts/src/main/java/de/intevation/flys/artifacts/states/ComputationRangeState.java Tue Nov 15 14:15:31 2011 +0000 @@ -41,7 +41,6 @@ private static Logger logger = Logger.getLogger(ComputationRangeState.class); - /** The name of the 'from' field. */ public static final String FROM = "ld_from"; @@ -55,7 +54,6 @@ public static final int DEFAULT_STEP = 100; - public ComputationRangeState() { }