# HG changeset patch
# User Felix Wolfsteller <felix.wolfsteller@intevation.de>
# Date 1324311533 0
# Node ID bb91cdf8407bfc353823d18512c6d51088bcca35
# Parent  8da36efc839a76b3cd2c24cfd70db773c81b157c
Minor refactoring to ease addition of new style-fields (are now added automically).

flys-client/trunk@3469 c6561f87-3c4e-4783-a992-168aeb5c3f6f

diff -r 8da36efc839a -r bb91cdf8407b flys-client/ChangeLog
--- a/flys-client/ChangeLog	Mon Dec 19 15:38:10 2011 +0000
+++ b/flys-client/ChangeLog	Mon Dec 19 16:18:53 2011 +0000
@@ -1,3 +1,13 @@
+2011-12-19	Felix Wolfsteller	<felix.wolfsteller@intevation.de>
+
+	Minor refactoring to ease addition of new (theme-style) settings.
+
+	* main/java/de/intevation/flys/client/shared/model/Style.java:
+	  Added getter for list of settings.
+
+	* main/java/de/intevation/flys/client/client/ui/StyleEditorWindow.java:
+	  Minor renaming, consume list instead of whitequerying entries.
+
 2011-12-19  Ingo Weinzierl <ingo@intevation.de>
 
 	* src/main/java/de/intevation/flys/client/server/CollectionHelper.java,
diff -r 8da36efc839a -r bb91cdf8407b flys-client/src/main/java/de/intevation/flys/client/client/ui/StyleEditorWindow.java
--- a/flys-client/src/main/java/de/intevation/flys/client/client/ui/StyleEditorWindow.java	Mon Dec 19 15:38:10 2011 +0000
+++ b/flys-client/src/main/java/de/intevation/flys/client/client/ui/StyleEditorWindow.java	Mon Dec 19 16:18:53 2011 +0000
@@ -155,8 +155,8 @@
     protected VLayout createPropertyGrid() {
         VLayout properties = new VLayout();
 
-        Theme t = facet.getTheme();
-        Style s = attributes.getStyle(t.getFacet(), t.getIndex());
+        Theme theme = facet.getTheme();
+        Style style = attributes.getStyle(theme.getFacet(), theme.getIndex());
 
         StaticTextItem name = new StaticTextItem("name", "Name");
         name.setValue(facet.getName());
@@ -164,25 +164,11 @@
         name.setTitleAlign(Alignment.LEFT);
         name.setDisabled(true);
         name.setShowDisabled(false);
-        DynamicForm f = new DynamicForm();
-        f.setFields(name);
-        properties.addMember(f);
+        DynamicForm form = new DynamicForm();
+        form.setFields(name);
+        properties.addMember(form);
 
-        String[] sets = {"showlines",
-                         "showpoints",
-                         "linetype",
-                         "linesize",
-                         "linecolor",
-                         "font",
-                         "textstyle",
-                         "textsize",
-                         "textcolor",
-                         "textorientation",
-                         "backgroundcolor",
-                         "showbackground"};
-
-        for (int i = 0; i < sets.length; i ++) {
-            StyleSetting set = s.getSetting(sets[i]);
+        for (StyleSetting set: style.getSettings()) {
 
             if (set == null) {
                 continue;
@@ -195,6 +181,7 @@
                 set.getDefaultValue());
             properties.addMember(property);
         }
+
         return properties;
     }
 
diff -r 8da36efc839a -r bb91cdf8407b flys-client/src/main/java/de/intevation/flys/client/shared/model/Style.java
--- a/flys-client/src/main/java/de/intevation/flys/client/shared/model/Style.java	Mon Dec 19 15:38:10 2011 +0000
+++ b/flys-client/src/main/java/de/intevation/flys/client/shared/model/Style.java	Mon Dec 19 16:18:53 2011 +0000
@@ -88,6 +88,16 @@
 
 
     /**
+     * Getter for style settings.
+     *
+     * @return The list of style settings.
+     */
+    public List<StyleSetting> getSettings() {
+        return this.settings;
+    }
+
+
+    /**
      * Getter for style setting.
      * @param i The index in the settings list.
      *