changeset 1517:a9388fba0b46

Cosmetics. flys-client/trunk@3670 c6561f87-3c4e-4783-a992-168aeb5c3f6f
author Felix Wolfsteller <felix.wolfsteller@intevation.de>
date Fri, 13 Jan 2012 09:47:27 +0000 (2012-01-13)
parents 102e472bd2a1
children e8706fec0ee9
files flys-client/ChangeLog flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ChartThemePanel.java flys-client/src/main/java/de/intevation/flys/client/shared/model/Theme.java
diffstat 3 files changed, 27 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/flys-client/ChangeLog	Thu Jan 12 16:57:26 2012 +0000
+++ b/flys-client/ChangeLog	Fri Jan 13 09:47:27 2012 +0000
@@ -1,3 +1,13 @@
+2012-01-13  Felix Wolfsteller <felix.wolfsteller@intevation.de>
+
+	Cosmetics.
+
+	* src/main/java/de/intevation/flys/client/shared/model/Theme.java:
+	  Doc added.
+
+	* src/main/java/de/intevation/flys/client/client/ui/chart/ChartThemePanel.java:
+	  Cosmetics, doc.
+
 2012-01-12  Raimund Renkert <raimund.renkert@intevation.de>
 
 	* src/main/java/de/intevation/flys/client/shared/model/MapArtifact.java,
--- a/flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ChartThemePanel.java	Thu Jan 12 16:57:26 2012 +0000
+++ b/flys-client/src/main/java/de/intevation/flys/client/client/ui/chart/ChartThemePanel.java	Fri Jan 13 09:47:27 2012 +0000
@@ -65,6 +65,7 @@
         de.intevation.flys.client.client.services.FeedService.class);
 
 
+    /** Constructor for a ChartThemePanel. */
     public ChartThemePanel(
         Collection collection,
         OutputMode mode,
@@ -142,6 +143,8 @@
         return "longitudinal_section.area";
     }
 
+
+    /** Create the DataProvider ('Blackboard') key for a theme. */
     public static String areaKey(Theme theme) {
         return theme.getArtifact() + ":" + theme.getFacet() + ":"
             + theme.getIndex();
@@ -174,7 +177,7 @@
                 DefaultData.createSimpleStringData("area.between",
                     (between)? "true" : "false")
             };
-            GWT.log("Have over and under");
+            GWT.log("Have 'over' and 'under' curve");
         }
         else if (over == null && under != null) {
             feedData = new Data[] {
@@ -187,7 +190,7 @@
                 DefaultData.createSimpleStringData("area.between",
                     (between)? "true" : "false")
             };
-            GWT.log("Have under only");
+            GWT.log("Have 'under' curve only");
         }
         else if (over != null && under == null) {
             feedData = new Data[] {
@@ -200,14 +203,13 @@
                 DefaultData.createSimpleStringData("area.between",
                     (between)? "true" : "false")
             };
-            GWT.log("Have over only");
+            GWT.log("Have 'over' curve only");
         }
         else {
             GWT.log("Missing Data for area painting.");
             return;
         }
 
-
         feedService.feed(
             Config.getInstance().getLocale(),
             new DefaultArtifact(artifact, "TODO:hash"),
@@ -269,7 +271,7 @@
                     feedTellArea(artifacts[0].getUuid(), under, over, between);
                 }
             }
-            );
+        );
     }
 
     
@@ -326,6 +328,7 @@
         ThemeList themes = getThemeList();
         int nThemes      = themes.getThemeCount();
 
+        // Create the "under..." submenu.
         MenuItem underMenuItem = new MenuItem(MSG.chart_themepanel_area_under());
         Menu underMenu = new Menu();
         for (int i = 0; i < nThemes; i++)  {
@@ -344,6 +347,7 @@
             });
         }
 
+        // Create the "over..." submenu.
         MenuItem overMenuItem = new MenuItem(MSG.chart_themepanel_area_over());
         Menu overMenu = new Menu();
         for (int i = 0; i < nThemes; i++)  {
@@ -371,6 +375,7 @@
         });
         overMenu.addItem(againstAxis);
 
+        // Create the "between..." submenu.
         MenuItem betweenMenuItem = new MenuItem(MSG.chart_themepanel_area_between());
         Menu betweenMenu = new Menu();
         for (int i = 0; i < nThemes; i++)  {
--- a/flys-client/src/main/java/de/intevation/flys/client/shared/model/Theme.java	Thu Jan 12 16:57:26 2012 +0000
+++ b/flys-client/src/main/java/de/intevation/flys/client/shared/model/Theme.java	Fri Jan 13 09:47:27 2012 +0000
@@ -6,6 +6,13 @@
 
 
 /**
+ * A 'Theme' is something displayed in a Chart. It can be activated or
+ * deactivated to show/hide in the resultant visual representation in the
+ * chart.
+ *
+ * A Theme maps more or less directly to a Facet of an Artifact in a
+ * Collection (certain attributes are added at Collection-Level).
+ *
  * @author <a href="mailto:ingo.weinzierl@intevation.de">Ingo Weinzierl</a>
  */
 public interface Theme extends Serializable {

http://dive4elements.wald.intevation.org