# HG changeset patch # User Björn Ricks # Date 1315828678 -7200 # Node ID 4912568f9048115fb95e5d82dbba1fc8d7fc246b # Parent 7c3f43bfc0a82e6aa52612ed49f59c4448077a7e Refactor delete_entries to do what it says: delete the entries passed as argument The provided entries weren't used to delete the entries from the database. A better method name would have been delete_selected_entries(). diff -r 7c3f43bfc0a8 -r 4912568f9048 getan.py --- a/getan.py Mon Sep 12 13:32:15 2011 +0200 +++ b/getan.py Mon Sep 12 13:57:58 2011 +0200 @@ -85,26 +85,14 @@ self.project_view.update_all() def delete_entries(self, entry_nodes): - if not entry_nodes: return - proj = None - entries = [] - try: - while self.entries_view.selection: - node = self.entries_view.selection.pop() - if node.selected: node.select() - entries.append(node.item) - logger.info("GetanController: delete entry '%s' (id = %d, "\ - "project id = %d)" - % (node.item.desc, node.item.id, - node.item.project_id)) - - if proj is None: - proj = self.project_by_id(node.item.project_id) - finally: - self.backend.delete_entries(entries) - proj.entries = self.backend.load_entries(proj.id) - self.update_entries(proj) - self.project_view.update() + if not entry_nodes: + return + proj = self.project_by_id(entry_nodes[0].project_id) + entries = entry_nodes + self.backend.delete_entries(entries) + proj.entries = self.backend.load_entries(proj.id) + self.update_entries(proj) + self.project_view.update() def update_project_list(self): self.project_view.update()