lada/lada-client: app/view/widgets/LadaForm.js comparison

comparison app/view/widgets/LadaForm.js @ 497:7c0653e8d9f7

Fixed some js related issues (unused vars, arrays, etc.) and code style.

author	Raimund Renkert <raimund.renkert@intevation.de>
date	Thu, 06 Nov 2014 10:38:17 +0100
parents	850ccfe5f3c4
children	8b4ec61c5752

comparison

equal deleted inserted replaced

-:d07e5086a64b
+:7c0653e8d9f7
 /* Copyright (C) 2013 by Bundesamt fuer Strahlenschutz
 * Software engineering by Intevation GmbH
 *
 * This file is Free Software under the GNU GPL (v>=3)
 * and comes with ABSOLUTELY NO WARRANTY! Check out
 * the documentation coming with IMIS-Labordaten-Application for details.
 */
 /**
 * Generic Lada specific form.
 *
 * Set to the id of the model instance and the model will be loaded for you.
 * Only applicable if model provided is a model class name (string).
 */
 modelId: null,
 /**
-* List of errors in the form. Typically set after the server validates the form submission
+* List of errors in the form.
+* Typically set after the server validates the form submission
 */
 errors: null,
 /**
-* List of warnings in the form. Typically set after the server validates the form submission
+* List of warnings in the form.
+* Typically set after the server validates the form submission
 */
 warnings: null,
 /**
-* The generic (error) message for the form. Typically set after the server validates the form submission
+* The generic (error) message for the form.
+* Typically set after the server validates the form submission
 */
 message: null,
 /**
-* Flag to indicate if the validation succeeds. Typically set after the server validates the form submission
+* Flag to indicate if the validation succeeds.
+* Typically set after the server validates the form submission
 */
 success: null,
 /**
 * Flag to indicate if the form should be rendered in readonly mode. Will
 * be set after calling the {setReadOnly} function.
 readonly: false,
 initComponent: function() {
 this.callParent(arguments);
-this.getForm().trackResetOnLoad = true; //Workaround
+this.getForm().trackResetOnLoad = true; // Workaround
 if (Ext.isString(this.model)) {
-//Load a model to be updated
+// Load a model to be updated
 if (this.modelId) {
 Ext.ClassManager.get(this.model).load(this.modelId, {
 failure: this.onModelLoadFailure,
 success: this.onModelLoadSuccess,
 scope: this
 });
-//Load an empty record to be inserted
+// Load an empty record to be inserted
 }
 else {
 this.bindModel(Ext.create(this.model, {}));
 }
 }
 else {
+// Bind the provided model to be updated
-//Bind the provided model to be updated
 this.bindModel(this.model);
 }
 this.addEvents(
 'loadsuccess',
 'loadfailure',
 'savesuccess',
 if (model.get('readonly') === true) {
 this.setReadOnly(true);
 }
 },
-commit: function(callback, scope) {
+commit: function() {
 if (this.form.isDirty() && this.form.isValid()) {
 this.form.updateRecord(this.model);
 var data = this.model.getAllData();
 var baseUrl = this.model.getProxy().url;
 var url = baseUrl;
-var method = "POST";
+var method = 'POST';
 if (this.model.getId()) {
 url += this.model.getId();
-method = "PUT";
+method = 'PUT';
 }
 Ext.Ajax.request({
 url: url,
 jsonData: data,
 method: method,
 callback: function(option, success, response) {
 this.parseResponse(response);
 if (this.success) {
 console.log('Save was successfull');
-this.fireEvent('savesuccess', this, this.model, response);
+this.fireEvent(
+'savesuccess',
+this,
+this.model,
+response);
 }
 else {
 console.log('Save was not successfull');
 this.form.markInvalid(this.errors);
-this.fireEvent('savefailure', this, this.model, response);
+this.fireEvent(
+'savefailure',
+this,
+this.model,
+response);
 }
 },
 scope: this
 });
 }
 * @param {Boolean} Flag to indicate if the form should be set to readonly
 * or not.
 * @param {Array} [ignoreFields="[]"] A list of fieldnames to ignore.
 */
 setReadOnly: function (bReadOnly, ignoreFields) {
-if(typeof(ignoreFields)==='undefined') {
+if (typeof (ignoreFields) === 'undefined') {
-ignoreFields = Array();
+ignoreFields = [];
 }
 /* Iterate over all fields and set them readonly */
 if (bReadOnly) {
-this.getForm().getFields().each (function (field) {
+this.getForm().getFields().each(function (field) {
 // Check if the field name is in the list of fields to ignore
 var ignore = false;
-for (var i = ignoreFields.length - 1; i >= 0; i--) {
+var k;
-console.log(ignoreFields[i] + "===" + field.getName());
+for (k = ignoreFields.length - 1; k >= 0; k--) {
-if (ignoreFields[i] === field.getName(true)) {
+console.log(ignoreFields[k] + '===' + field.getName());
+if (ignoreFields[k] === field.getName(true)) {
 ignore = true;
-};
+}
-};
+}
-//field.setDisabled(bReadOnly);
+// field.setDisabled(bReadOnly);
 if (!ignore) {
 field.setReadOnly(true);
 }
 });
 /* Iterate over all toolbars of lists and hide them */
 }
 /*
 * Find Save-Button and hide it. Only hide it if there are not
 * fields left in the form which are editable
 * */
-if (ignoreFields.length == 0) {
+if (ignoreFields.length === 0) {
 var win = this.up('window');
 var buttons = win.query('.button');
 for (var j = buttons.length - 1; j >= 0; j--) {
 if (buttons[j].text === 'Speichern') {
 buttons[j].setVisible(false);
-};
+}
-};
+}
 }
 }
 },
 parseResponse: function(response) {
 if (json) {
 this.success = json.success;
 this.errors = this.translateReturnCodes(json.errors);
 this.warnings = this.translateReturnCodes(json.warnings);
 this.message = Lada.getApplication().bundle.getMsg(json.message);
-var e = Ext.Object.isEmpty(this.warnings);
 if (!Ext.Object.isEmpty(this.warnings) ||
 !Ext.Object.isEmpty(this.errors)) {
 this.createMessages();
 }
 }
 createMessages: function() {
 var messages = Ext.create('Ext.form.Panel', {
 bodyPadding: '5 5 5 5'
 });
-for (var key in this.warnings) {
+var key;
-var label = Ext.create('Ext.container.Container', {
+var label;
+for (key in this.warnings) {
+label = Ext.create('Ext.container.Container', {
 layout: 'hbox',
 bodyPadding: '5 5 5 5',
 items: [{
 xtype: 'image',
 src: 'gfx/icon-warning.gif',
 width: 18,
 height: 18
 }, {
 xtype: 'label',
-text: key + ": " + this.warnings[key],
+text: key + ': ' + this.warnings[key],
 margin: '4 0 0 5'
 }]
 });
 messages.insert(0, label);
 }
-for (var key in this.errors) {
+for (key in this.errors) {
-var label = Ext.create('Ext.container.Container', {
+label = Ext.create('Ext.container.Container', {
 layout: 'hbox',
 bodyPadding: '5 5 5 5',
 items: [{
 xtype: 'image',
 src: 'gfx/icon-error.gif',
 width: 18,
 height: 18
 }, {
 xtype: 'label',
-text: key + ": " + this.errors[key],
+text: key + ': ' + this.errors[key],
 margin: '4 0 0 5'
 }]
 });
 messages.insert(0, label);
 }

http://lada.wald.intevation.org