# HG changeset patch # User Torsten Irländer # Date 1370608231 -7200 # Node ID bd41680cc7d5ab1aacf351d0fff698ffb0b38953 # Parent 8830934533b5d4e45aef89891b48f0eebf83bff0 Changed type of return to Response and removed handling of errors and warnings. This is now done in the Response object. diff -r 8830934533b5 -r bd41680cc7d5 src/main/java/de/intevation/lada/rest/LProbeService.java --- a/src/main/java/de/intevation/lada/rest/LProbeService.java Fri Jun 07 14:29:27 2013 +0200 +++ b/src/main/java/de/intevation/lada/rest/LProbeService.java Fri Jun 07 14:30:31 2013 +0200 @@ -115,58 +115,12 @@ @POST @Produces("text/json") @Consumes("application/json") - public String create(LProbe probe) { + public Response create(LProbe probe) { boolean success = repository.create(probe); int generalError = repository.getGeneralError(); - if(success) { - return "{" + - "success: true, " + - "message: \"" + generalError + "\", " + - "errors: {" + createErrorFields() + "}, " + - "warnings: {" + createWarningFields() + "}" + - "}"; - } - else { - return "{" + - "success: false, " + - "message: \"" + generalError + "\", " + - "errors: {" + createErrorFields() + "}, " + - "warnings: {" + createWarningFields() + "}" + - "}"; - } - } - - private String createWarningFields() { - Map warnings = repository.getWarnings(); - String response = ""; - if (warnings == null || warnings.isEmpty()) { - return response; - } - boolean first = true; - for (Map.Entry entry: warnings.entrySet()) { - if (!first) { - response +=","; - } - response += entry.getKey() + ":" + "\"" + entry.getValue() + "\""; - first = false; - } - return response; - } - - private String createErrorFields() { - Map errors = repository.getErrors(); - String response = ""; - if (errors.isEmpty()) { - return response; - } - boolean first = true; - for (Map.Entry entry: errors.entrySet()) { - if (!first) { - response +=","; - } - response += entry.getKey() + ":" + "\"" + entry.getValue() + "\""; - first = false; - } + Response response = new Response(success, generalError, probe); + response.setWarnings(repository.getWarnings()); + response.setErrors(repository.getErrors()); return response; } }