mxd2map: src/java/de/intevation/mxd/writer/MapScriptWriter.java comparison

comparison src/java/de/intevation/mxd/writer/MapScriptWriter.java @ 314:cd3cb1a7f35a

Workaround a bug in ArcGIS causing FieldNames of shape files that are 11 Characters long to be postfixed with their Type Identifier.

author	Andre Heinecke <aheinecke@intevation.de>
date	Mon, 17 Sep 2012 17:02:15 +0200
parents	c8b8f887ef80
children	1d77ea6a915d

comparison

equal deleted inserted replaced

-:9bb629743d2c
+:cd3cb1a7f35a
 layerElement.getAttribute("join_table") + "." +
 layerElement.getAttribute("join_field"));
 }
 else {
 prefix = layerElement.getAttribute("data_source");
+if (!prefix.isEmpty()) {
+prefix += ".";
+}
 if(layerElement.hasAttribute("definition_query") &&
 !layerElement.getAttribute("definition_query")
 .equals("")) {
 layer.setFilter("where " +
 layerElement.getAttribute("definition_query"));
 // ogr expression fields come prefixed from arcgis
 // the prefix has to be removed in order to work with
 // mapserver
 String unwantedPrefix = layerElement.getAttribute("data") + ".";
 logger.debug("Removing expression Prefix: " + unwantedPrefix);
-expr = expr.replace(unwantedPrefix, "");
+boolean isShapeFile = false;
+if (layerElement.getAttribute("connection_type") == "local") {
+isShapeFile = true;
+}
+expr = sanitizeAttribute(expr,
+unwantedPrefix, prefix, isShapeFile);
 }
 if(!prefix.equals("")) {
 expr = prefix + "." + expr;
 }
 layer.setLabelitem(expr.trim());
 //Write classes.
 writeClass(layer, layerElement);
 }
 return true;
+}
+/**
+* Adds the elements (Features) to the layer.
+* @param layer        Mapscript layer object.
+* @param layerElement Dom element containing the feature attributes.
+*/
+private void writeFeatures(layerObj layer, Element layerElement) {
+NodeList list = layerElement.getElementsByTagName("feature");
+for(int i = 0; i < list.getLength(); i++) {
+logger.debug("Writing an element");
+Element feature = (Element)list.item(i);
+pointObj poi = new pointObj(
+Double.parseDouble(feature.getAttribute("X")),
+Double.parseDouble(feature.getAttribute("Y")),
+0.0, -2e38);
+lineObj line = new lineObj();
+line.add(poi);
+logger.debug("Set the line");
+shapeObj shape = new shapeObj(MS_SHAPE_TYPE.MS_SHAPE_POINT.swigValue());
+shape.add(line);
+shape.setText(feature.getAttribute("text"));
+// Write the Style / Symbol once
+if ( i == 0 ) {
+classObj co = new classObj(layer);
+writeLabel(co, feature, layerElement.getAttribute("type"));
+MarkerStyleWriter swriter = new MarkerStyleWriter (this.map, co);
+swriter.write((Element)feature.getFirstChild());
+}
+layer.addFeature(shape);
+}
 }
 /**
 * Adds the classes to the layer.
 * @param layer        Mapscript layer object.
 }
 //Create definition expression.
 if(classElement.hasAttribute("field_count")) {
 String unwantedPrefix = layerElement.getAttribute("data") + ".";
-co.setExpression(createExpression(classElement, i, unwantedPrefix));
+boolean isShapeFile = false;
+if (layerElement.getAttribute("connection_type") == "local") {
+isShapeFile = true;
+}
+co.setExpression(createExpression(classElement, i, unwantedPrefix, isShapeFile));
 }
 //Write symbols and styles.
 NodeList l = classElement.getChildNodes();
 for (int j = l.getLength() - 1; j >= 0; j--) {
 label.setPosition(MS_POSITIONS_ENUM.MS_UC.swigValue());
 }
 }
 }
+/** Sanitze an attribute
+*
+* Fixes invalid Field names and/or adds and removes a prefix
+*
+* @param attribute The Attribute to sanitize
+* @param prefixToRemove A Prefix that should be removed (empty otherwise)
+* @param prefixToAdd A Prefix that should be added (empty otherwise)
+* @param enforceShpLimit True if the attribute should follow shapefile
+* format restrictions.
+*/
+private String sanitizeAttribute(String attribute, String prefixToRemove,
+String prefixToAdd, boolean enforceShpLimit) {
+if (enforceShpLimit) {
+/* Workaround for non standard conform shapefile implementations
+* like the one used by ArcGis that appends the field type after the
+* eleventh character. Although the standard actually defines 10
+* as the maximum length of Field Names GDAL handles the case where
+* the terminating 0 is actually a Character allowing for Field
+* names of up to 11 characters.
+*/
+if (attribute.length() > 10) {
+// Just remove the Type Delimiter
+if (attribute.endsWith("C") ||
+attribute.endsWith("D") ||
+attribute.endsWith("N") ||
+attribute.endsWith("L") ||
+attribute.endsWith("M")) {
+attribute = attribute.substring(0, attribute.length() - 1);
+}
+}
+}
+if (!prefixToRemove.isEmpty() && attribute.startsWith(prefixToRemove)) {
+attribute = attribute.replace(prefixToRemove, "");
+}
+if (!prefixToAdd.isEmpty() && !attribute.startsWith(prefixToAdd)) {
+attribute = prefixToAdd + attribute;
+}
+return attribute;
+}
 /**
 * Create definition expression.
 *
 * @param ce DOM elementcontaining the class expression information.
 * @param index Index to determine the correct expression operator.
 * @param prefixToRemove A string that will be removed from the start of
 * expression fields.
-*/
+* @param isShapeFile true if shapefile attribute limits should be enforced
-private String createExpression(Element ce, int index, String prefixToRemove) {
+*/
+private String createExpression(Element ce, int index, String prefixToRemove,
+boolean isShapeFile) {
 String expression = "(";
 int count = 0;
 try {
 count = Integer.parseInt(ce.getAttribute("field_count"));
 }
 if(count == 1) {
 //Create single field expression.
 try {
 //If no exception is thrown, the expression value is a number.
 Double.parseDouble(ce.getAttribute("value"));
-String exp = ce.getAttribute("expression_field_0");
+expression += "[" +
-String pre = "";
+sanitizeAttribute(ce.getAttribute("expression_field_0"),
-if (!prefix.equals("") && !exp.startsWith(prefix)) {
+prefixToRemove, prefix, isShapeFile) + "]";
-pre = prefix + ".";
-}
-expression += "[" + pre;
-expression += ce.getAttribute("expression_field_0").replace(
-prefixToRemove, "") + "]";
 if(ce.hasAttribute("min_value")) {
 if(index == 0) {
 expression += " >= " + ce.getAttribute("min_value");
 }
 else {
 expression += " > " + ce.getAttribute("min_value");
 }
-expression += " AND [" + pre;
+expression += " AND [" +
-expression += ce.getAttribute("expression_field_0").replace(
+sanitizeAttribute(ce.getAttribute("expression_field_0"),
-prefixToRemove, "");
+prefixToRemove, prefix, isShapeFile) + "]";
 expression += "]";
 }
 expression += " " + ce.getAttribute("expression_operator");
 expression += " " + ce.getAttribute("value") + ")";
 }
 catch(NumberFormatException nfe) {
 //The expression value is a strings.
-String exp = ce.getAttribute("expression_field_0").replace(
+expression += "\"[";
-prefixToRemove, "");
+expression += sanitizeAttribute(ce.getAttribute("expression_field_0"),
-String pre = "";
+prefixToRemove, prefix, isShapeFile) + "]";
-if (!prefix.equals("") && !exp.startsWith(prefix)) {
-pre = prefix + ".";
-}
-expression += "\"[" + pre;
-expression += ce.getAttribute("expression_field_0").replace(
-prefixToRemove, "") + "]\"";
 expression += " " + ce.getAttribute("expression_operator");
 expression += " \"" + ce.getAttribute("value") + "\")";
 }
 catch(Exception e) {
 e.printStackTrace();
 for (int i = 0; i < count; i++) {
 try {
 //If no exception is thrown, the expression values are
 //numbers.
 Double.parseDouble(ce.getAttribute("value_" + i));
-String exp = ce.getAttribute("expression_field_" + i).replace(
+expression += "[";
-prefixToRemove, "");
+expression += sanitizeAttribute(ce.getAttribute("expression_field_" + i),
-String pre = "";
+prefixToRemove, prefix, isShapeFile);
-if (!prefix.equals("") && !exp.startsWith(prefix)) {
-pre = prefix + ".";
-}
-expression += "[" + pre;
-expression += ce.getAttribute("expression_field_" + i).replace(
-prefixToRemove, "");
 expression += "]";
 expression += " " + ce.getAttribute("expression_operator");
 expression += " " + ce.getAttribute("value_" + i);
 if (i < count - 1) {
 expression += " AND ";
 expression += ")";
 }
 }
 catch (NumberFormatException nfe) {
 //The expression values are strings.
-String exp = ce.getAttribute("expression_field_" + i).replace(
+expression += "\"[";
-prefixToRemove, "");
+expression += sanitizeAttribute(ce.getAttribute("expression_field_" + i),
-String pre = "";
+prefixToRemove, prefix, isShapeFile);
-if (!prefix.equals("") && !exp.startsWith(prefix)) {
-pre = prefix + ".";
-}
-expression += "\"[" + pre;
-expression += ce.getAttribute("expression_field_" + i).replace(
-prefixToRemove, "");
 expression += "]\"";
 expression += " " + ce.getAttribute("expression_operator");
 expression += " \"" + ce.getAttribute("value_" + i);
 if (i < count - 1) {
 expression += "\" AND ";

Mercurial > mxd2map

comparison src/java/de/intevation/mxd/writer/MapScriptWriter.java @ 314:cd3cb1a7f35a