# HG changeset patch # User Bernhard Herzog # Date 1259668327 0 # Node ID 61d1daac23d4d3a61dd58169bb3e92942dfb6581 # Parent 5f442b0cf3a49554440b1ecae5342854148b3aa5 Move the should_stop check out of the try/except block so that it's not skipped when a build fails. diff -r 5f442b0cf3a4 -r 61d1daac23d4 treepkg/packager.py --- a/treepkg/packager.py Tue Dec 01 11:47:52 2009 +0000 +++ b/treepkg/packager.py Tue Dec 01 11:52:07 2009 +0000 @@ -655,14 +655,14 @@ if packager: packager.package() repeat = self.install_dependencies(track, packager) - if self.should_stop(): - logging.info("Received stop instruction. Stopping.") - return True except: logging.exception("An error occurred while" " checking packager track %r", track.name) if self.stop_on_error: raise + if self.should_stop(): + logging.info("Received stop instruction. Stopping.") + return True if repeat: logging.info("Built binaries needed by other tracks." " Starting over to ensure all dependencies"