# HG changeset patch # User Bernhard Herzog # Date 1213878367 0 # Node ID 71053890860932b560f1db29749035d1c8d22be8 # Parent 017179427c7f9b8378fb9bb3f285347b33498468 kdepim recipe: raise an error if not all version replacements could be done diff -r 017179427c7f -r 710538908609 recipes/kde_enterprise_3_5/kdepim.py --- a/recipes/kde_enterprise_3_5/kdepim.py Thu Jun 19 12:25:30 2008 +0000 +++ b/recipes/kde_enterprise_3_5/kdepim.py Thu Jun 19 12:26:07 2008 +0000 @@ -43,12 +43,17 @@ """Overrides the inherited method to update version numbers in the code """ versionstring = "(enterprise35 %s)" % self.enterprise_version + failed = [] for versionfile in ["kmail/kmversion.h", "kontact/src/main.cpp", "korganizer/version.h"]: - #FIXME: should check successful replacements - treepkg.util.replace_in_file(os.path.join(pkgbasedir, versionfile), - "\(enterprise35 ([^)]*)\)", - versionstring) + if not treepkg.util.replace_in_file(os.path.join(pkgbasedir, + versionfile), + "\(enterprise35 ([^)]*)\)", + versionstring): + failed.append(versionfile) + if failed: + raise RuntimeError("kdepim: failed to update version numbers in %s" + % (", ".join(failed),)) def do_package(self): pkgbaseversion, pkgbasedir = self.export_sources()