Mercurial > trustbridge
comparison ui/installwrapper.cpp @ 1162:2a1206932f53
(issue107) Comment all TODO's and FIXME's with issues as documented in issue107
| author | Andre Heinecke <andre.heinecke@intevation.de> |
|---|---|
| date | Thu, 18 Sep 2014 18:53:11 +0200 |
| parents | 0ddb173bcd8b |
| children | c8f698ca6355 |
comparison
equal
deleted
inserted
replaced
| 1161:b67681a61e3e | 1162:2a1206932f53 |
|---|---|
| 59 return true; | 59 return true; |
| 60 } | 60 } |
| 61 | 61 |
| 62 void InstallWrapper::run() | 62 void InstallWrapper::run() |
| 63 { | 63 { |
| 64 /* TODO: We need errorcodes here so that we can see if a user | |
| 65 * cancled the UAC elevation */ | |
| 66 QTemporaryFile choicesFile; | 64 QTemporaryFile choicesFile; |
| 67 QFileInfo cinstProcInfo = getCinstProcInfo(); | 65 QFileInfo cinstProcInfo = getCinstProcInfo(); |
| 68 | 66 |
| 69 QString cinstFileName = QDir::toNativeSeparators( | 67 QString cinstFileName = QDir::toNativeSeparators( |
| 70 getCinstProcInfo().absoluteFilePath()); | 68 getCinstProcInfo().absoluteFilePath()); |
| 169 } | 167 } |
| 170 CloseHandle(shExecInfo.hProcess); | 168 CloseHandle(shExecInfo.hProcess); |
| 171 fclose(vres.fptr); | 169 fclose(vres.fptr); |
| 172 | 170 |
| 173 if (retval != 0) { | 171 if (retval != 0) { |
| 174 /* TODO make this nicer */ | 172 /* TODO (issue135) make this nicer */ |
| 175 emit error (tr("The process failed with return code. %1").arg(retval)); | 173 emit error (tr("The process failed with return code. %1").arg(retval)); |
| 176 return; | 174 return; |
| 177 } | 175 } |
| 178 #else /* WIN32 */ | 176 #else /* WIN32 */ |
| 179 QProcess installerProcess; | 177 QProcess installerProcess; |
| 237 } | 235 } |
| 238 | 236 |
| 239 if (installerProcess.exitCode() == 0) { | 237 if (installerProcess.exitCode() == 0) { |
| 240 qDebug() << "output: " << installerProcess.readAllStandardOutput(); | 238 qDebug() << "output: " << installerProcess.readAllStandardOutput(); |
| 241 } else { | 239 } else { |
| 242 /* TODO handle errors defined by errorcodes.h */ | 240 /* TODO (issue135) handle errors defined by errorcodes.h */ |
| 243 qDebug() << "Installer Process returned: " << installerProcess.exitCode(); | 241 qDebug() << "Installer Process returned: " << installerProcess.exitCode(); |
| 244 qDebug() << "output: " << installerProcess.readAllStandardOutput(); | 242 qDebug() << "output: " << installerProcess.readAllStandardOutput(); |
| 245 return; | 243 return; |
| 246 } | 244 } |
| 247 #endif | 245 #endif |