Mercurial > trustbridge
comparison ui/createinstallerdialog.cpp @ 1268:2efdf2faf4e5
Remove dead variable and fix possible null pointer dereference
Problems found by clang static-analyzer
| author | Andre Heinecke <andre.heinecke@intevation.de> |
|---|---|
| date | Fri, 26 Sep 2014 19:31:53 +0200 |
| parents | 2a1206932f53 |
| children | 137a0686de7b |
comparison
equal
deleted
inserted
replaced
| 1267:d9ecf3a83620 | 1268:2efdf2faf4e5 |
|---|---|
| 462 } | 462 } |
| 463 | 463 |
| 464 /* Check that it is a 3072 bit RSA key as specified */ | 464 /* Check that it is a 3072 bit RSA key as specified */ |
| 465 if (!pk.pk_info || pk_get_size(&pk) != 3072 || | 465 if (!pk.pk_info || pk_get_size(&pk) != 3072 || |
| 466 pk.pk_info->type != POLARSSL_PK_RSA) { | 466 pk.pk_info->type != POLARSSL_PK_RSA) { |
| 467 qDebug() << pk.pk_info->type << "type"; | 467 if (pk.pk_info) { |
| 468 qDebug() << pk.pk_info->type << "type"; | |
| 469 } | |
| 468 qDebug() << POLARSSL_PK_RSA << "rsa"; | 470 qDebug() << POLARSSL_PK_RSA << "rsa"; |
| 469 qDebug() << "size " << pk_get_size(&pk); | 471 qDebug() << "size " << pk_get_size(&pk); |
| 470 showErrorMessage(tr("Only 3072 bit RSA keys are supported by the current format.")); | 472 showErrorMessage(tr("Only 3072 bit RSA keys are supported by the current format.")); |
| 471 pk_free(&pk); | 473 pk_free(&pk); |
| 472 return false; | 474 return false; |