trustbridge: ui/mainwindow.cpp comparison

comparison ui/mainwindow.cpp @ 1227:a1e990947172

(issue38) Add long time error handling. A Long Time Error is an error that will be shown to the user if it happened at least seven times with an interval of at least a day between occurances. After one success a long time error will be reset.

author	Andre Heinecke <andre.heinecke@intevation.de>
date	Wed, 24 Sep 2014 15:12:40 +0200
parents	1171a4778562
children	05b938021a24

comparison

equal deleted inserted replaced

-:e401680b0cbd
+:a1e990947172
 QString availableFileName = mSettings.value("List/available").toString();
 QString installedFileName = mSettings.value("List/installed").toString();
 if (!availableFileName.isEmpty()) {
 mListToInstall.readList(availableFileName.toUtf8().constData());
 if (!mListToInstall.isValid()) {
+handleLTE(lteInvalidList);
 mCurState = TransferError;
-// Probably a bug when Qt fileName is encoded and cFileName
-// fails because of this. This needs a unit test!
-// Maybe check that the file is in our data directory
 QFile::remove(availableFileName);
 mSettings.remove("List/available");
 mSettings.remove("List/availableDate");
+} else {
+handleLTE(lteInvalidList, true);
 }
 } else {
 // Make sure the available notation is also removed
 mSettings.remove("List/available");
 mSettings.remove("List/availableDate");
 }
 bin_verify_result verifyResult = verify_binary(swFileName.toUtf8().constData(),
 swFileName.toUtf8().size());
 qDebug() << "Binary verify result: " << verifyResult.result;
 if (verifyResult.result != VerifyValid) {
+handleLTE(lteInvalidSoftware);
 qDebug() << "Failed to verify downloaded data.";
 QFile::remove(swFileName);
 mSettings.remove("Software/available");
 mSettings.remove("Software/availableDate");
 return;
 }
+handleLTE(lteInvalidSoftware, true); /* Reset error state */
 fclose(verifyResult.fptr);
 }
 void MainWindow::handleNewList(const QString& fileName, const QDateTime& modDate) {
 qDebug() << "new list available";
 mSettings.setValue("List/available", fileName);
 mSettings.setValue("List/availableDate", modDate);
 verifyListData();
 if (!mListToInstall.isValid()) {
+handleLTE(lteInvalidList);
 /* Downloader provided invalid files */
-/* TODO (issue38): Error count. Error handling. Otherwise
-* we can go into an endless loop here */
 /* Retry the download again in 10 - 20 minutes */
 QTimer::singleShot(600000 + (qrand() % 60000), this, SLOT(checkUpdates()));
 qDebug() << "Failed to verify list.";
 } else {
 mSettings.sync();
 showMessage();
 }
-QString getPrettyInstallerName(QString realFileName) {
+QString MainWindow::getPrettyInstallerName(QString realFileName) {
 QTemporaryDir tDir;
 if (!tDir.isValid()) {
 qDebug () << "Failed to create temporary directory.";
+showErrorMessage (tr("Failed to create temporary directory.") + "\n" +
+tr("Please ensure that you have the access rights to write in "
+"the temporary directory and that there is at least 20MB free "
+"disk space available."));
 return QString();
 }
 QString targetPath = tDir.path() + "/" + QObject::tr("TrustBridge-Updater",
 "Used as filename for the updater. Only use ASCII please.");
 tDir.setAutoRemove(false);
 #ifdef WIN32
 targetPath += ".exe";
 #endif
 if (!QFile::copy(realFileName, targetPath)) {
+showErrorMessage (tr("Failed to create a temporary copy of the installer.") + "\n" +
+tr("Please ensure that you have the access rights to write in "
+"the temporary directory and that there is at least 20MB free "
+"disk space available."));
 qDebug() << "Failed to create temporary copy of installer.";
 }
 return targetPath;
 }
 /* Copy the file to a temporary name for installation */
 filePath = getPrettyInstallerName(filePath);
 if (filePath.isEmpty()) {
 qDebug() << "Failed to copy updater to temporary location.";
-showErrorMessage(tr("Failed to create update process.") + "\n" +
-tr("This could be caused by not enough disk space or invalid permissions."));
 return;
 }
 mSettings.setValue("Software/Updater", filePath); /* So it can be deleted
 on next start */
 mSettings.sync();
 bin_verify_result vres = verify_binary(filePath.toUtf8().constData(),
 filePath.toUtf8().size());
 if (vres.result != VerifyValid) {
+handleLTE(lteInvalidSoftware);
 qDebug() << "Invalid software. Not installing";
 return;
 }
+handleLTE(lteInvalidSoftware, true);
 QFileInfo fi(QCoreApplication::applicationFilePath());
 QDir installDir = fi.absoluteDir();
 #ifdef WIN32
 QString parameters = QString::fromLatin1("/S /UPDATE=1 /D=") +
 checkUpdates();
 }
 void MainWindow::downloaderError(const QString &message, SSLConnection::ErrorCode error)
 {
-/* TODO (issue38) handle error according to a plan */
 syslog_error_printf ("Failed to check for updates: %s", message.toUtf8().constData());
+if (error == SSLConnection::InvalidCertificate) {
+handleLTE(lteInvalidCertificate);
+} else {
+handleLTE(lteNoConnection);
+}
 #ifdef IS_TAG_BUILD
 /* During tag build it should never happen that an url checked is not available
 * during development this is normal as each revision produces a new url. */
 setState(TransferError);
 if (!isVisible()) {
 mSettings.setValue("lastUpdateCheck", now);
 mLastUpdateCheckContents->setText(QLocale::system().toString(now, DATETIME_FORMAT));
 mLastUpdateCheckContents->show();
 mLastUpdateCheck->show();
 syslog_info_printf(tr("Sucessfully checked for updates.").toUtf8().constData());
+handleLTE(lteNoConnection, true); /* Reset error state */
+handleLTE(lteInvalidCertificate, true);
 }
 if ((getState() != NewSoftwareAvailable && getState() != NewListAvailable && mTrayMode)
 && !isVisible()) {
 qDebug() << "Shutting down as no list or Software is available.";
 closeApp();
 void MainWindow::showErrorMessage(const QString &msg)
 {
 QMessageBox::warning(this, tr("TrustBridge error"), msg);
 }
+void MainWindow::handleLTE(LongTimeErrors lte, bool reset)
+{
+QString settingPrefix;
+switch (lte) {
+case lteInvalidSoftware:
+settingPrefix = "LTE/invalidSW";
+break;
+case lteInvalidList:
+settingPrefix = "LTE/invalidList";
+break;
+case lteInvalidCertificate:
+settingPrefix = "LTE/invalidCertificate";
+break;
+case lteNoConnection:
+settingPrefix = "LTE/noConnection";
+break;
+default:
+qDebug() << "Unhandled error. " << lte;
+}
+if (reset) {
+/* delete all values and be done */
+mSettings.remove(settingPrefix + "_lastSaved");
+mSettings.remove(settingPrefix + "_count");
+mSettings.remove(settingPrefix + "_lastMsgShown");
+return;
+}
+QDateTime lastSaved = mSettings.value(settingPrefix + "_lastSaved").toDateTime();
+bool cnt_valid;
+int cnt = mSettings.value(settingPrefix + "_count").toInt(&cnt_valid);
+if (!cnt_valid) {
+cnt = 0;
+}
+if (!lastSaved.isValid() || lastSaved.daysTo(QDateTime::currentDateTime()) >= 1) {
+/* The error count is increased at most once a day */
+mSettings.setValue(settingPrefix + "_lastSaved", QDateTime::currentDateTime());
+mSettings.setValue(settingPrefix + "_count", ++cnt);
+}
+if (cnt < 7) {
+/* We are done */
+return;
+}
+/* A week has passed. Start showing the error. */
+QDateTime lastShown = mSettings.value(settingPrefix + "_lastShown").toDateTime();
+if (lastShown.isValid() && lastShown.daysTo(QDateTime::currentDateTime()) < 1) {
+/* Only show the error message once a day */
+return;
+}
+mSettings.setValue(settingPrefix + "_lastShown", QDateTime::currentDateTime());
+switch (lte) {
+case lteInvalidSoftware:
+showErrorMessage(tr("The integrity check for the available software update has "
+"failed repeatedly.") + "\n" +
+tr("Please contact your Support or the publisher of the Software."));
+break;
+case lteInvalidList:
+showErrorMessage(tr("The integrity check of the available certificates has "
+"failed repeatedly.") + "\n" +
+tr("Please contact your Support or the publisher of the Software."));
+break;
+case lteInvalidCertificate:
+showErrorMessage(tr("The authentication of the download server has "
+"failed repeatedly.") + "\n" +
+tr("Please contact your Support or the publisher of the Software."));
+break;
+case lteNoConnection:
+bool useProxy = mSettings.value("UseProxy", false).toBool();
+if (useProxy) {
+showErrorMessage(tr("The connection to the download server has "
+"failed repeatedly.") + "\n" +
+tr("Please check that the Proxy Server \"%1\" is available.").arg(
+mSettings.value("ProxyURL").toString()));
+} else {
+showErrorMessage(tr("The connection to the download server has "
+"failed repeatedly.") + "\n" +
+tr("Please check your internet connection."));
+}
+break;
+}
+}

Mercurial > trustbridge

comparison ui/mainwindow.cpp @ 1227:a1e990947172