Mercurial > trustbridge
changeset 518:31e0a86f5a35
Actually set the arguments for makensis process. Fix escaping
author | Andre Heinecke <aheinecke@intevation.de> |
---|---|
date | Tue, 29 Apr 2014 09:25:51 +0000 |
parents | a3e027cd0683 |
children | 6e11dc2f70d3 |
files | ui/createinstallerdialog.cpp |
diffstat | 1 files changed, 6 insertions(+), 6 deletions(-) [+] |
line wrap: on
line diff
--- a/ui/createinstallerdialog.cpp Mon Apr 28 17:15:48 2014 +0000 +++ b/ui/createinstallerdialog.cpp Tue Apr 29 09:25:51 2014 +0000 @@ -159,11 +159,13 @@ void CreateInstallerDialog::processFinished(int exitCode, QProcess::ExitStatus exitStatus) { + qDebug() << "Finished: " << mNSISProc.readAll(); mProgress.cancel(); } void CreateInstallerDialog::processError(QProcess::ProcessError error) { + qDebug() << "Error: " << mNSISProc.readAll(); mProgress.cancel(); } @@ -195,16 +197,18 @@ /* Copy windows directory contents to tmpdir */ QStringList arguments; mNSISProc.setProgram("makensis"); + mNSISProc.setProcessChannelMode(QProcess::MergedChannels); mNSISProc.setWorkingDirectory(outDir.path()); arguments << QString::fromLatin1("-Dfiles_dir=") + binDir.path() + "/windows"; - foreach (const QString &key, keys) { - arguments << QString::fromLatin1("-D%1=\"%2\"").arg(key, + arguments << QString::fromLatin1("-D%1=%2").arg(key, options.value(key, QString()).toString()); } arguments << binDir.path() + "/trustbridge.nsi"; + qDebug() << "Starting makensis with arguments: " << arguments; + mNSISProc.setArguments(arguments); mNSISProc.start(); mProgress.show(); @@ -213,8 +217,4 @@ showErrorMessage(tr("Failed to start makensis.\n" "Please ensure that makensis is installed and in your PATH variable.")); } - - - - }