# HG changeset patch # User Andre Heinecke # Date 1392893840 0 # Node ID fec1a610d43f451ea5d54d269a6222b6ce58e23c # Parent 9af6198deb8ea822da1d1ba538eab02210492393 Mark usage of goto with TODOs to remove them diff -r 9af6198deb8e -r fec1a610d43f ui/downloader_win.cpp --- a/ui/downloader_win.cpp Thu Feb 20 10:56:49 2014 +0000 +++ b/ui/downloader_win.cpp Thu Feb 20 10:57:20 2014 +0000 @@ -277,6 +277,8 @@ QTime(lMod.wHour, lMod.wMinute, lMod.wSecond, lMod.wMilliseconds), Qt::UTC); + +// TODO remove and replace with a smart handle cleanup: if (hRequest) { WinHttpCloseHandle(hRequest); @@ -429,6 +431,7 @@ } } while (bytesAvailable > 0); +// TODO remove and replace with a smart handle cleanup: if (retval && outputFile.isOpen()) { @@ -546,6 +549,8 @@ DEBUG << "Error" << GetLastError(); emit error(tr("Unknown Problem when connecting"), ErrUnknown); } + +// TODO remove and replace with a smart handle cleanup: if (hConnect) { WinHttpCloseHandle(hConnect);